You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ashutosh Mestry via Review Board <no...@reviews.apache.org> on 2019/06/03 04:54:23 UTC
Re: Review Request 70768: ATLAS-3256 Modify export API to process with
relationshipAttributes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70768/#review215634
-----------------------------------------------------------
Can you please add:
- Results of export -> import -> export testing.
- Performance improvement numbers for the new extract strategy.
- Please test with 2.6.x files.
repository/src/main/java/org/apache/atlas/repository/impexp/EntitiesExtractor.java
Lines 50 (patched)
<https://reviews.apache.org/r/70768/#comment302410>
Replace string with constant defined above.
repository/src/main/java/org/apache/atlas/repository/impexp/RelationshipAttributesExtractor.java
Lines 64 (patched)
<https://reviews.apache.org/r/70768/#comment302414>
Won't this do fullFetch?
repository/src/main/java/org/apache/atlas/repository/impexp/VertexExtractor.java
Lines 97 (patched)
<https://reviews.apache.org/r/70768/#comment302411>
Replace this function call with if (LOG.isDebugEnabled()) {LOG.debug(...); }
repository/src/main/java/org/apache/atlas/repository/impexp/VertexExtractor.java
Lines 182 (patched)
<https://reviews.apache.org/r/70768/#comment302412>
Remove this method.
- Ashutosh Mestry
On May 31, 2019, 12:21 p.m., Nikhil Bonte wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70768/
> -----------------------------------------------------------
>
> (Updated May 31, 2019, 12:21 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, madhan, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3256
> https://issues.apache.org/jira/browse/ATLAS-3256
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Please refer jira for description
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/impexp/EntitiesExtractor.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 11289ea
> repository/src/main/java/org/apache/atlas/repository/impexp/ExtractStrategy.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/impexp/IncrementalExportEntityProvider.java 3a2a917
> repository/src/main/java/org/apache/atlas/repository/impexp/RelationshipAttributesExtractor.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/impexp/VertexExtractor.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/impexp/IncrementalExportEntityProviderTest.java 85ed5f9
> repository/src/test/java/org/apache/atlas/repository/impexp/RelationshipAttributesExtractorTest.java PRE-CREATION
> repository/src/test/resources/hive_db_lineage.zip PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/70768/diff/2/
>
>
> Testing
> -------
>
> Added UTs
> Test cases are passing
>
>
> Thanks,
>
> Nikhil Bonte
>
>
Re: Review Request 70768: ATLAS-3256 Modify export API to process with
relationshipAttributes
Posted by Nikhil Bonte <ni...@freestoneinfotech.com>.
> On June 3, 2019, 4:54 a.m., Ashutosh Mestry wrote:
> > repository/src/main/java/org/apache/atlas/repository/impexp/RelationshipAttributesExtractor.java
> > Lines 64 (patched)
> > <https://reviews.apache.org/r/70768/diff/2/?file=2147440#file2147440line64>
> >
> > Won't this do fullFetch?
seperated logic to avoid confusion
- Nikhil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70768/#review215634
-----------------------------------------------------------
On May 31, 2019, 12:21 p.m., Nikhil Bonte wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70768/
> -----------------------------------------------------------
>
> (Updated May 31, 2019, 12:21 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, madhan, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3256
> https://issues.apache.org/jira/browse/ATLAS-3256
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Please refer jira for description
>
> Will add Performance improvement numbers soon.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/impexp/EntitiesExtractor.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 11289ea
> repository/src/main/java/org/apache/atlas/repository/impexp/ExtractStrategy.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/impexp/IncrementalExportEntityProvider.java 3a2a917
> repository/src/main/java/org/apache/atlas/repository/impexp/RelationshipAttributesExtractor.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/impexp/VertexExtractor.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/impexp/IncrementalExportEntityProviderTest.java 85ed5f9
> repository/src/test/java/org/apache/atlas/repository/impexp/RelationshipAttributesExtractorTest.java PRE-CREATION
> repository/src/test/resources/hive_db_lineage.zip PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/70768/diff/3/
>
>
> Testing
> -------
>
> Added UTs
> Test cases are passing
>
> Manual testing approach:
> 1. exported data > data1.zip
> 2. cleaned hbase & solr
> 3. imported data1.zip & verified imported data
> 4. exported again > data2.zip
> 5. compared contents of data1.zip & data2.zip
>
>
> Thanks,
>
> Nikhil Bonte
>
>