You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/12/27 21:05:00 UTC
[GitHub] [druid] suneet-s opened a new pull request #9101: Link javaOpts to
middlemanager runtime.properties docs
suneet-s opened a new pull request #9101: Link javaOpts to middlemanager runtime.properties docs
URL: https://github.com/apache/druid/pull/9101
The s3 extension and hadoop operations documentation references the javaOpts property.
Reference the documentation about setting this property to make it easier for new users to
know how to set the property.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #9101:
Link javaOpts to middlemanager runtime.properties docs
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #9101: Link javaOpts to middlemanager runtime.properties docs
URL: https://github.com/apache/druid/pull/9101#discussion_r365490059
##########
File path: docs/operations/other-hadoop.md
##########
@@ -55,7 +55,7 @@ Generally, you should only set one of these parameters, not both.
These properties can be set in either one of the following ways:
- Using the task definition, e.g. add `"mapreduce.job.classloader": "true"` to the `jobProperties` of the `tuningConfig` of your indexing task (see the [Hadoop batch ingestion documentation](../ingestion/hadoop.md)).
-- Using system properties, e.g. on the MiddleManager set `druid.indexer.runner.javaOpts=... -Dhadoop.mapreduce.job.classloader=true`.
+- Using system properties, e.g. on the MiddleManager set `druid.indexer.runner.javaOpts=... -Dhadoop.mapreduce.job.classloader=true` in [middleManager/runtime.properties](../configuration/index.md#middlemanager-configuration).
Review comment:
same as previous comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #9101:
Link javaOpts to middlemanager runtime.properties docs
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #9101: Link javaOpts to middlemanager runtime.properties docs
URL: https://github.com/apache/druid/pull/9101#discussion_r365488772
##########
File path: docs/development/extensions-core/s3.md
##########
@@ -38,7 +38,7 @@ The AWS SDK requires that the target region be specified. Two ways of doing this
As an example, to set the region to 'us-east-1' through system properties:
- Add `-Daws.region=us-east-1` to the jvm.config file for all Druid services.
-- Add `-Daws.region=us-east-1` to `druid.indexer.runner.javaOpts` in middleManager/runtime.properties so that the property will be passed to Peon (worker) processes.
+- Add `-Daws.region=us-east-1` to `druid.indexer.runner.javaOpts` in [middleManager/runtime.properties](../../configuration/index.md#middlemanager-configuration) so that the property will be passed to Peon (worker) processes.
Review comment:
I think it would be more correct to just refer to it as middle manager configuration instead of 'middleManager/runtime.properties', since you don't necessarily have to use those files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #9101: Link javaOpts to
middlemanager runtime.properties docs
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #9101: Link javaOpts to middlemanager runtime.properties docs
URL: https://github.com/apache/druid/pull/9101
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org