You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Jacques Le Roux (Jira)" <ji...@apache.org> on 2020/11/18 16:21:00 UTC
[jira] [Assigned] (OFBIZ-12061) Comment out
HideUtilityClassConstructor in checkstyle.xml
[ https://issues.apache.org/jira/browse/OFBIZ-12061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reassigned OFBIZ-12061:
---------------------------------------
Assignee: Jacques Le Roux
> Comment out HideUtilityClassConstructor in checkstyle.xml
> ---------------------------------------------------------
>
> Key: OFBIZ-12061
> URL: https://issues.apache.org/jira/browse/OFBIZ-12061
> Project: OFBiz
> Issue Type: Improvement
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Major
>
> Currently Checkstyle returns 222 occurrences of the message "Utility classes should not have a public or default constructor."
> This is due to https://checkstyle.sourceforge.io/config_design.html#HideUtilityClassConstructor
> I don't think we need to follow the "prevents calls from subclass" suggestion there.
> I rather suggest to comment out the related class in checkstyle.xml:
> bq. ie <!-- <module name="HideUtilityClassConstructor"/> -->
> Then should remain only 280 errors and hopefully most will be easy to fix. At least they will be easier to spot...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)