[GitHub] [submarine] pingsutw commented on a change in pull request #132: SUBMARINE-296 [SDK] Submarine pipeline example

[GitBox <gi...@apache.org>]

pingsutw commented on a change in pull request #132: SUBMARINE-296 [SDK] Submarine pipeline example
URL: https://github.com/apache/submarine/pull/132#discussion_r361062775
 
 

 ##########
 File path: submarine-sdk/pysubmarine/example/deepFM.json
 ##########
 @@ -0,0 +1,31 @@
+{
+  "input": {
+    "train_data": "./data/tr.libsvm",
 
 Review comment:
   @tangzhankun Thanks for the review. I like hyphen as well, but I follow other model convention like [xgboost](https://xgboost.readthedocs.io/en/latest/parameter.html), [sklearn](https://scikit-learn.org/stable/auto_examples/linear_model/plot_ols.html), it looks like data scientists much prefer to underscore

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org