You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by vo...@apache.org on 2023/10/11 14:32:13 UTC

[myfaces] branch 4.0.x updated: Fix MYFACES-4628

This is an automated email from the ASF dual-hosted git repository.

volosied pushed a commit to branch 4.0.x
in repository https://gitbox.apache.org/repos/asf/myfaces.git


The following commit(s) were added to refs/heads/4.0.x by this push:
     new f02f49c51 Fix MYFACES-4628
     new 808078df3 Merge pull request #626 from volosied/MYFACES-4628-4.0.x
f02f49c51 is described below

commit f02f49c51567773d027370c0ff8c44d98b167c51
Author: Volodymyr Siedlecki <vo...@gmail.com>
AuthorDate: Thu Sep 21 16:28:01 2023 -0400

    Fix MYFACES-4628
---
 .../java/org/apache/myfaces/renderkit/html/util/HtmlRendererUtils.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/impl/src/main/java/org/apache/myfaces/renderkit/html/util/HtmlRendererUtils.java b/impl/src/main/java/org/apache/myfaces/renderkit/html/util/HtmlRendererUtils.java
index 163929e8e..06982f9e7 100644
--- a/impl/src/main/java/org/apache/myfaces/renderkit/html/util/HtmlRendererUtils.java
+++ b/impl/src/main/java/org/apache/myfaces/renderkit/html/util/HtmlRendererUtils.java
@@ -312,7 +312,7 @@ public final class HtmlRendererUtils
                     Object selectItemValue = itemInfo.getItem().getValue();
                     String convertedValue = SharedRendererUtils.getConvertedStringValue(
                         facesContext,component,((ValueHolder) component).getConverter(), selectItemValue);
-                    if(convertedValue.equals(selectItemValue))
+                    if(convertedValue.equals(submittedValue))
                     {   // disabled value matches submitted value
                         submittedValue = RendererUtils.EMPTY_STRING;
                     }