You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by "JiaLiangC (via GitHub)" <gi...@apache.org> on 2023/12/19 01:48:49 UTC
[PR] BIGTOP-4051: Add python3 dependency for Phoenix deb [bigtop]
JiaLiangC opened a new pull request, #1216:
URL: https://github.com/apache/bigtop/pull/1216
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g., 'BIGTOP-3638: Your PR title ...'.
-->
### Description of PR
In the minimal Python code of phoenix 5.1.3, there is a handling for Python that allows it to support both Python 3 and Python 2. Therefore, a dependency on Python 3 is added in the Phoenix deb package because many systems only have Python 3 by default. Not adding this dependency would result in users being unable to install Phoenix properly.
The code related to Python 3 compatibility can be found at:
https://github.com/apache/phoenix/blob/5.1.3/bin/daemon.py#L66
### How was this patch tested?
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
- [ ] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BIGTOP-4051: Add python3 dependency for Phoenix deb [bigtop]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC closed pull request #1216: BIGTOP-4051: Add python3 dependency for Phoenix deb
URL: https://github.com/apache/bigtop/pull/1216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BIGTOP-4051: Add python3 dependency for Phoenix deb [bigtop]
Posted by "iwasakims (via GitHub)" <gi...@apache.org>.
iwasakims commented on PR #1216:
URL: https://github.com/apache/bigtop/pull/1216#issuecomment-2062889108
@JiaLiangC How about removing dependency on Python for aligning with other activities in BIGTOP-4052? The manifests of bigtop-deploy must be fixed if you need tweak the environment for running smoke-tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BIGTOP-4051: Add python3 dependency for Phoenix deb [bigtop]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC commented on PR #1216:
URL: https://github.com/apache/bigtop/pull/1216#issuecomment-2062891665
@iwasakims
I agree with removing the Python dependency. I will close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org