You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "chirag shah (JIRA)" <ji...@apache.org> on 2009/10/31 02:26:59 UTC
[jira] Created: (SHINDIG-1215) Honor the maxObjSize in
BasicHttpFetcher and make it configurable
Honor the maxObjSize in BasicHttpFetcher and make it configurable
-----------------------------------------------------------------
Key: SHINDIG-1215
URL: https://issues.apache.org/jira/browse/SHINDIG-1215
Project: Shindig
Issue Type: Bug
Components: Java
Reporter: chirag shah
Honor the maximum allowed object size when reading the response body of an HTTP request in BasicHttpFetcher.
Also make maxObjSize and connectionTimeoutMs configurable via Guice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-1215) Honor the maxObjSize in
BasicHttpFetcher and make it configurable
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772205#action_12772205 ]
Henry Saputra commented on SHINDIG-1215:
----------------------------------------
Maybe we could log something if the bytes read is greater than max object size.
> Honor the maxObjSize in BasicHttpFetcher and make it configurable
> -----------------------------------------------------------------
>
> Key: SHINDIG-1215
> URL: https://issues.apache.org/jira/browse/SHINDIG-1215
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Reporter: chirag shah
> Attachments: SHINDIG-1215.patch.diff
>
>
> Honor the maximum allowed object size when reading the response body of an HTTP request in BasicHttpFetcher.
> Also make maxObjSize and connectionTimeoutMs configurable via Guice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-1215) Honor the maxObjSize in
BasicHttpFetcher and make it configurable
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-1215.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.1-BETA4
Patch applied with modifications. I made these parameters optional and used setter injection instead. Also made the max object size in bytes volatile and correctly closed the streams when we hit an error condition and return a 400 response instead of a truncated file.
Thanks!
Paul
> Honor the maxObjSize in BasicHttpFetcher and make it configurable
> -----------------------------------------------------------------
>
> Key: SHINDIG-1215
> URL: https://issues.apache.org/jira/browse/SHINDIG-1215
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Reporter: chirag shah
> Fix For: 1.1-BETA4
>
> Attachments: SHINDIG-1215.patch.diff
>
>
> Honor the maximum allowed object size when reading the response body of an HTTP request in BasicHttpFetcher.
> Also make maxObjSize and connectionTimeoutMs configurable via Guice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1215) Honor the maxObjSize in
BasicHttpFetcher and make it configurable
Posted by "chirag shah (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
chirag shah updated SHINDIG-1215:
---------------------------------
Attachment: SHINDIG-1215.patch.diff
Attached is a patch for SHINDIG-1215.
> Honor the maxObjSize in BasicHttpFetcher and make it configurable
> -----------------------------------------------------------------
>
> Key: SHINDIG-1215
> URL: https://issues.apache.org/jira/browse/SHINDIG-1215
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Reporter: chirag shah
> Attachments: SHINDIG-1215.patch.diff
>
>
> Honor the maximum allowed object size when reading the response body of an HTTP request in BasicHttpFetcher.
> Also make maxObjSize and connectionTimeoutMs configurable via Guice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.