[jira] Commented: (MAPREDUCE-1010) Adding tests for changes in archives.

["Tom White (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766002#action_12766002 ] 

Tom White commented on MAPREDUCE-1010:
--------------------------------------

This looks good. Is it worth adding a comment in the test to say it's testing HARs containing files with "escape-worthy characters" in their names? (Minor nit: there's an error in the line {{assertTrue("Should read 6 bytes.", readBytes == 8);}})

Also, are you planning on adding a test for the LineReader reset part of HADOOP-6097?

> Adding tests for changes in archives.
> -------------------------------------
>
>                 Key: MAPREDUCE-1010
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1010
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: harchive
>    Affects Versions: 0.20.1
>            Reporter: Mahadev konar
>            Assignee: Mahadev konar
>            Priority: Minor
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1010.patch
>
>
> Created this jira so that the tests can be added for HADOOP-6047. The test cases for hadoop archives are in mapreduce.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.