[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #257: Daffodil 2165 type calc double functions

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #257: Daffodil 2165 type calc double functions
URL: https://github.com/apache/incubator-daffodil/pull/257#discussion_r299601545
 
 

 ##########
 File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/DPathRuntime.scala
 ##########
 @@ -95,7 +99,7 @@ class CompiledDPath(val ops: RecipeOp*) extends Serializable {
         // in a way that is not consistent with a constant expression. Such as trying to do
         // anything with the infoset other than saving and restoring current position in the infoset.
         // Ditto trying to read a variable.
-        case _: InfosetException | _: VariableException | _: java.lang.IllegalStateException =>
+        case _: InfosetException | _: VariableException | _: NoSuchElementException | _: java.lang.IllegalStateException =>
 
 Review comment:
   What causes this NoSuchElementException? I thought we only want to catch Daffodil specific exceptions here, like the infoset stuff or variable stuff? NoSuchELementException implies to me that we have a bug somewhere and are accessing somethign we shouldn't.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services