You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by karol-brejna-i <gi...@git.apache.org> on 2017/02/21 14:00:17 UTC
[GitHub] incubator-gearpump pull request #157: [GEARPUMP-236] Using new sbt-assembly ...
GitHub user karol-brejna-i opened a pull request:
https://github.com/apache/incubator-gearpump/pull/157
[GEARPUMP-236] Using new sbt-assembly version to fix java.lang.Verify\u2026
\u2026Error
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the commit message is formatted like:
`[GEARPUMP-<Jira issue #>] Meaningful description of pull request`
- [x] Make sure tests pass via `sbt clean test`.
- [x] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality.
Two tests (not related) fail:
[info] - should authenticate the authorization code and return the correct profile *** FAILED ***
[info] - should authenticate the authorization code and return the correct profile *** FAILED ***
[info] *** 2 TESTS FAILED ***
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karol-brejna-i/incubator-gearpump GEARPUMP-236
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/157.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #157
----
commit 947e1b518ee0360ed5c6905051349147a859e883
Author: karol brejna <ka...@intel.com>
Date: 2017-02-21T13:54:10Z
[GEARPUMP-236] Using new sbt-assembly version to fix java.lang.VerifyError
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #157: [GEARPUMP-236] Using new sbt-assembly version...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/157
# [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/157?src=pr&el=h1) Report
> Merging [#157](https://codecov.io/gh/apache/incubator-gearpump/pull/157?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/0e56f83ce8586cc1dcbf57103f6b884fc4138d6a?src=pr&el=desc) will **decrease** coverage by `-0.28%`.
> The diff coverage is `100%`.
```diff
@@ Coverage Diff @@
## master #157 +/- ##
==========================================
- Coverage 71.85% 71.57% -0.28%
==========================================
Files 191 191
Lines 6069 6066 -3
Branches 527 526 -1
==========================================
- Hits 4361 4342 -19
- Misses 1708 1724 +16
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/157?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `\u0394 = absolute <relative> (impact)`, `� = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/157?src=pr&el=footer). Last update [0e56f83...947e1b5](https://codecov.io/gh/apache/incubator-gearpump/compare/0e56f83ce8586cc1dcbf57103f6b884fc4138d6a...947e1b518ee0360ed5c6905051349147a859e883?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #157: [GEARPUMP-236] Using new sbt-assembly version...
Posted by karol-brejna-i <gi...@git.apache.org>.
Github user karol-brejna-i commented on the issue:
https://github.com/apache/incubator-gearpump/pull/157
I saw them. I don't have a working hadoop cluster right now, so I had no way to confirm it work.
I'll get myself a cluster soon, make the additional changes and test it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #157: [GEARPUMP-236] Using new sbt-assembly ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/157
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #157: [GEARPUMP-236] Using new sbt-assembly version...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/157
`-noverify` is also added [here](https://github.com/apache/incubator-gearpump/blob/master/experiments/yarn/src/main/scala/org/apache/gearpump/experiments/yarn/appmaster/Command.scala#L51) and [here](https://github.com/apache/incubator-gearpump/blob/master/experiments/yarn/src/test/scala/org/apache/gearpump/experiments/yarn/client/LaunchClusterSpec.scala#L189). Could you remove them as well ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #157: [GEARPUMP-236] Using new sbt-assembly version...
Posted by karol-brejna-i <gi...@git.apache.org>.
Github user karol-brejna-i commented on the issue:
https://github.com/apache/incubator-gearpump/pull/157
Removed novverify from yarn related code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---