You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/12 07:48:57 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #31816: [SPARK-34724][SQL] Fix Interpreted evaluation by using getMethod instead of getDeclaredMethod
dongjoon-hyun opened a new pull request #31816:
URL: https://github.com/apache/spark/pull/31816
…
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31816: [SPARK-34724][SQL] Fix Interpreted evaluation by using getMethod instead of getDeclaredMethod
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31816:
URL: https://github.com/apache/spark/pull/31816#issuecomment-797607250
Thank you all!
And, no problem at all, @kiszk !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #31816: [SPARK-34724][SQL] Fix Interpreted evaluation by using getMethod instead of getDeclaredMethod
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #31816:
URL: https://github.com/apache/spark/pull/31816#issuecomment-797306165
cc @kiszk , @hvanhovell , @viirya since this was introduced at SPARK-23583.
Also, cc @cloud-fan , @rednaxelafx , @maropu, @HyukjinKwon because this was found when we fix `CodegenInterpretedPlanTest` via https://github.com/apache/spark/pull/31766 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #31816: [SPARK-34724][SQL] Fix Interpreted evaluation by using getMethod instead of getDeclaredMethod
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #31816:
URL: https://github.com/apache/spark/pull/31816#issuecomment-797306165
cc @kiszk , @hvanhovell , @viirya since this was introduced at SPARK-23583.
Also, cc @cloud-fan , @rednaxelafx , @maropu, @HyukjinKwon because this was found when we introduced `testFallback`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31816: [SPARK-34724][SQL] Fix Interpreted evaluation by using getMethod instead of getDeclaredMethod
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31816:
URL: https://github.com/apache/spark/pull/31816#issuecomment-797529880
good catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #31816: [SPARK-34724][SQL] Fix Interpreted evaluation by using getMethod instead of getDeclaredMethod
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31816:
URL: https://github.com/apache/spark/pull/31816
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #31816: [SPARK-34724][SQL] Fix Interpreted evaluation by using getMethod instead of getDeclaredMethod
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #31816:
URL: https://github.com/apache/spark/pull/31816#issuecomment-797306165
cc @kiszk , @hvanhovell , @viirya since this is introduced at SPARK-23583.
Also, cc @cloud-fan , @rednaxelafx , @maropu, @HyukjinKwon because this was found when we introduced `testFallback`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #31816: [SPARK-34724][SQL] Fix Interpreted evaluation by using getMethod instead of getDeclaredMethod
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #31816:
URL: https://github.com/apache/spark/pull/31816#issuecomment-797306165
cc @kiszk , @hvanhovell , @viirya since this was introduced at SPARK-23583.
Also, cc @cloud-fan , @rednaxelafx , @maropu, @HyukjinKwon because this was found when we introduced `testFallback` via https://github.com/apache/spark/pull/31766 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31816: [SPARK-34724][SQL] Fix Interpreted evaluation by using getMethod instead of getDeclaredMethod
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31816:
URL: https://github.com/apache/spark/pull/31816#issuecomment-797306165
cc @kiszk , @hvanhovell , @viirya since this is introduced at SPARK-23583.
Also, cc @cloud-fan , @rednaxelafx , @maropu because this was found when we introduced `testFallback`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31816: [SPARK-34724][SQL] Fix Interpreted evaluation by using getMethod instead of getDeclaredMethod
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31816:
URL: https://github.com/apache/spark/pull/31816#discussion_r593152039
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -333,7 +333,7 @@ case class Invoke(
val invokeMethod = if (method.isDefined) {
method.get
} else {
- obj.getClass.getDeclaredMethod(functionName, argClasses: _*)
+ obj.getClass.getMethod(functionName, argClasses: _*)
Review comment:
Nice catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31816: [SPARK-34724][SQL] Fix Interpreted evaluation by using getMethod instead of getDeclaredMethod
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31816:
URL: https://github.com/apache/spark/pull/31816#issuecomment-797359484
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40579/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] rednaxelafx commented on pull request #31816: [SPARK-34724][SQL] Fix Interpreted evaluation by using getMethod instead of getDeclaredMethod
Posted by GitBox <gi...@apache.org>.
rednaxelafx commented on pull request #31816:
URL: https://github.com/apache/spark/pull/31816#issuecomment-797719522
Post review: thank you for catching and fixing this! The new `testFallback` feature is obviously more useful than what it first seems, very nice!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31816: [SPARK-34724][SQL] Fix Interpreted evaluation by using getMethod instead of getDeclaredMethod
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31816:
URL: https://github.com/apache/spark/pull/31816#issuecomment-797332020
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135995/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31816: [SPARK-34724][SQL] Fix Interpreted evaluation by using getMethod instead of getDeclaredMethod
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31816:
URL: https://github.com/apache/spark/pull/31816#issuecomment-797462014
Merged to master, branch-3.1, branch-3.0 and branch-2.4.
@kiszk, it's fine. I made worse mistakes much more than you did :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org