You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by shazron <gi...@git.apache.org> on 2016/10/07 23:28:35 UTC
[GitHub] cordova-ios pull request #266: CB-11729 - template file MainViewController.m...
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/266
CB-11729 - template file MainViewController.m has deprecated override shouldAutorotateToInterfaceOrientation
### Platforms affected
iOS
### What does this PR do?
Remove unused selector in MainViewController subclass, add in comments the new overrides available.
### What testing has been done on this change?
Local build
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-ios CB-11729
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/266.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #266
----
commit d71cb97fa31c8e59df10dffa3fc6cb927e2deb42
Author: Shazron Abdullah <sh...@apache.org>
Date: 2016-10-07T23:26:36Z
CB-11729 - template file MainViewController.m has deprecated override shouldAutorotateToInterfaceOrientation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #266: CB-11729 - template file MainViewController.m has de...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/266
## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/266?src=pr) is 56.50% (diff: 100%)
> Merging [#266](https://codecov.io/gh/apache/cordova-ios/pull/266?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will not change coverage
```diff
@@ master #266 diff @@
==========================================
Files 12 12
Lines 1230 1230
Methods 198 198
Messages 0 0
Branches 193 193
==========================================
Hits 695 695
Misses 535 535
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [636113f...d71cb97](https://codecov.io/gh/apache/cordova-ios/compare/636113f047ee2c7dae742dff2beafae2121ceb62...d71cb97fa31c8e59df10dffa3fc6cb927e2deb42?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #266: CB-11729 - template file MainViewController.m...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/266
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org