You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/12 03:16:46 UTC

[GitHub] [flink] wuchong commented on a change in pull request #11063: [FLINK-15938][table-planner-blink] Enable state cleanup in background…

wuchong commented on a change in pull request #11063: [FLINK-15938][table-planner-blink] Enable state cleanup in background…
URL: https://github.com/apache/flink/pull/11063#discussion_r378021090
 
 

 ##########
 File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/join/stream/state/JoinRecordStateViews.java
 ##########
 @@ -79,6 +79,7 @@ static StateTtlConfig createTtlConfig(long retentionTime, boolean stateCleaningE
 				.newBuilder(Time.milliseconds(retentionTime))
 				.setUpdateType(StateTtlConfig.UpdateType.OnCreateAndWrite)
 				.setStateVisibility(StateTtlConfig.StateVisibility.ReturnExpiredIfNotCleanedUp)
+				.cleanupInBackground()
 
 Review comment:
   `cleanupInBackground()` is enabled by default and this method is deprecated. Do we add this in master?
   From my understanding, we only need to update 1.9 branch. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services