You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bharat kumar <bh...@citrix.com> on 2013/06/26 17:54:38 UTC

Review Request 12109: HAProxy maxconn is not configurable

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12109/
-----------------------------------------------------------

Review request for cloudstack and Abhinandan Prateek.


Bugs: Cloudstack-2997


Repository: cloudstack-git


Description
-------

Cloudstack-2997 HAProxy maxconn is not configurable
https://issues.apache.org/jira/browse/CLOUDSTACK-2997


Diffs
-----

  api/src/com/cloud/offering/NetworkOffering.java 5f522eb 
  api/src/org/apache/cloudstack/api/ApiConstants.java b43f06c 
  api/src/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java febb0c3 
  api/src/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java ba685a9 
  core/src/com/cloud/agent/api/routing/LoadBalancerConfigCommand.java 1c1fb91 
  core/src/com/cloud/network/HAProxyConfigurator.java 29fdf4a 
  engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java fae315b 
  plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java b21e8f9 
  plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java 2bdb28f 
  plugins/network-elements/internal-loadbalancer/test/org/apache/cloudstack/internallbvmmgr/InternalLBVMManagerTest.java a19a82e 
  server/src/com/cloud/configuration/Config.java 2b0ffaf 
  server/src/com/cloud/configuration/ConfigurationManager.java 8db037b 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java 97f0d33 
  server/src/com/cloud/network/NetworkManagerImpl.java 8c2806a 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 7f3a88e 
  server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 21b3590 
  server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java 4a2c867 
  setup/db/db/schema-410to420.sql 181f1cb 

Diff: https://reviews.apache.org/r/12109/diff/


Testing
-------

Tested on master.


Thanks,

bharat kumar

Re: Review Request 12109: HAProxy maxconn is not configurable

Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12109/#review22896
-----------------------------------------------------------



core/src/com/cloud/network/HAProxyConfigurator.java
<https://reviews.apache.org/r/12109/#comment46642>

    You need not cast globalSection to a List just do globalSection[2] = "\tmaxconn " + lbCmd.maxconn;


- Abhinandan Prateek


On July 1, 2013, 3:55 p.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12109/
> -----------------------------------------------------------
> 
> (Updated July 1, 2013, 3:55 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy.
> 
> 
> Bugs: Cloudstack-2997
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Cloudstack-2997 HAProxy maxconn is not configurable
> https://issues.apache.org/jira/browse/CLOUDSTACK-2997
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/offering/NetworkOffering.java 5f522eb 
>   api/src/org/apache/cloudstack/api/ApiConstants.java b43f06c 
>   api/src/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java febb0c3 
>   api/src/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java ba685a9 
>   core/src/com/cloud/agent/api/routing/LoadBalancerConfigCommand.java 1c1fb91 
>   core/src/com/cloud/network/HAProxyConfigurator.java 29fdf4a 
>   engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java fae315b 
>   plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java b21e8f9 
>   plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java 2bdb28f 
>   plugins/network-elements/internal-loadbalancer/test/org/apache/cloudstack/internallbvmmgr/InternalLBVMManagerTest.java a19a82e 
>   server/src/com/cloud/configuration/Config.java 2b0ffaf 
>   server/src/com/cloud/configuration/ConfigurationManager.java 8db037b 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 97f0d33 
>   server/src/com/cloud/network/NetworkManagerImpl.java 8c2806a 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 7f3a88e 
>   server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 21b3590 
>   server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java 4a2c867 
>   setup/db/db/schema-410to420.sql 181f1cb 
> 
> Diff: https://reviews.apache.org/r/12109/diff/
> 
> 
> Testing
> -------
> 
> Tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 12109: HAProxy maxconn is not configurable

Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12109/#review22895
-----------------------------------------------------------



core/src/com/cloud/agent/api/routing/LoadBalancerConfigCommand.java
<https://reviews.apache.org/r/12109/#comment46641>

    Max connection should be int ?


- Abhinandan Prateek


On July 1, 2013, 3:55 p.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12109/
> -----------------------------------------------------------
> 
> (Updated July 1, 2013, 3:55 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy.
> 
> 
> Bugs: Cloudstack-2997
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Cloudstack-2997 HAProxy maxconn is not configurable
> https://issues.apache.org/jira/browse/CLOUDSTACK-2997
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/offering/NetworkOffering.java 5f522eb 
>   api/src/org/apache/cloudstack/api/ApiConstants.java b43f06c 
>   api/src/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java febb0c3 
>   api/src/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java ba685a9 
>   core/src/com/cloud/agent/api/routing/LoadBalancerConfigCommand.java 1c1fb91 
>   core/src/com/cloud/network/HAProxyConfigurator.java 29fdf4a 
>   engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java fae315b 
>   plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java b21e8f9 
>   plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java 2bdb28f 
>   plugins/network-elements/internal-loadbalancer/test/org/apache/cloudstack/internallbvmmgr/InternalLBVMManagerTest.java a19a82e 
>   server/src/com/cloud/configuration/Config.java 2b0ffaf 
>   server/src/com/cloud/configuration/ConfigurationManager.java 8db037b 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 97f0d33 
>   server/src/com/cloud/network/NetworkManagerImpl.java 8c2806a 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 7f3a88e 
>   server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 21b3590 
>   server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java 4a2c867 
>   setup/db/db/schema-410to420.sql 181f1cb 
> 
> Diff: https://reviews.apache.org/r/12109/diff/
> 
> 
> Testing
> -------
> 
> Tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 12109: HAProxy maxconn is not configurable

Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12109/#review23233
-----------------------------------------------------------

Ship it!


Ship It!

- Abhinandan Prateek


On July 17, 2013, 2:07 a.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12109/
> -----------------------------------------------------------
> 
> (Updated July 17, 2013, 2:07 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy.
> 
> 
> Bugs: Cloudstack-2997
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Cloudstack-2997 HAProxy maxconn is not configurable
> https://issues.apache.org/jira/browse/CLOUDSTACK-2997
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/offering/NetworkOffering.java 43312db 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 83999b6 
>   api/src/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java 94e263c 
>   api/src/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java ba685a9 
>   core/src/com/cloud/agent/api/routing/LoadBalancerConfigCommand.java 1c1fb91 
>   core/src/com/cloud/network/HAProxyConfigurator.java 162571f 
>   engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java 6317f72 
>   plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java 5f603b3 
>   plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java 5d6a671 
>   plugins/network-elements/internal-loadbalancer/test/org/apache/cloudstack/internallbvmmgr/InternalLBVMManagerTest.java a19a82e 
>   server/src/com/cloud/configuration/Config.java e77f6ce 
>   server/src/com/cloud/configuration/ConfigurationManager.java 1b99b63 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 7e0bc25 
>   server/src/com/cloud/network/NetworkManagerImpl.java 42430bc 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 7bd2864 
>   server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 7a61978 
>   server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java 36564d9 
>   setup/db/db/schema-410to420.sql e9fa995 
> 
> Diff: https://reviews.apache.org/r/12109/diff/
> 
> 
> Testing
> -------
> 
> Tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 12109: HAProxy maxconn is not configurable

Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12109/
-----------------------------------------------------------

(Updated July 17, 2013, 3:41 a.m.)


Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy.


Changes
-------

rebased with master.


Bugs: Cloudstack-2997


Repository: cloudstack-git


Description
-------

Cloudstack-2997 HAProxy maxconn is not configurable
https://issues.apache.org/jira/browse/CLOUDSTACK-2997


Diffs (updated)
-----

  api/src/com/cloud/offering/NetworkOffering.java 43312db 
  api/src/org/apache/cloudstack/api/ApiConstants.java 83999b6 
  api/src/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java 94e263c 
  api/src/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java ba685a9 
  core/src/com/cloud/agent/api/routing/LoadBalancerConfigCommand.java 1c1fb91 
  core/src/com/cloud/network/HAProxyConfigurator.java 162571f 
  engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java 6317f72 
  plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java 9c34a8b 
  plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java 5d6a671 
  plugins/network-elements/internal-loadbalancer/test/org/apache/cloudstack/internallbvmmgr/InternalLBVMManagerTest.java a19a82e 
  server/src/com/cloud/configuration/Config.java e77f6ce 
  server/src/com/cloud/configuration/ConfigurationManager.java 1b99b63 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java fd170bd 
  server/src/com/cloud/network/NetworkManagerImpl.java f6e9a0a 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 0a67cff 
  server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 7a61978 
  server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java 9825cab 
  setup/db/db/schema-410to420.sql e9fa995 

Diff: https://reviews.apache.org/r/12109/diff/


Testing
-------

Tested on master.


Thanks,

bharat kumar

Re: Review Request 12109: HAProxy maxconn is not configurable

Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12109/
-----------------------------------------------------------

(Updated July 17, 2013, 2:07 a.m.)


Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy.


Changes
-------

Rebased with master


Bugs: Cloudstack-2997


Repository: cloudstack-git


Description
-------

Cloudstack-2997 HAProxy maxconn is not configurable
https://issues.apache.org/jira/browse/CLOUDSTACK-2997


Diffs (updated)
-----

  api/src/com/cloud/offering/NetworkOffering.java 43312db 
  api/src/org/apache/cloudstack/api/ApiConstants.java 83999b6 
  api/src/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java 94e263c 
  api/src/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java ba685a9 
  core/src/com/cloud/agent/api/routing/LoadBalancerConfigCommand.java 1c1fb91 
  core/src/com/cloud/network/HAProxyConfigurator.java 162571f 
  engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java 6317f72 
  plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java 5f603b3 
  plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java 5d6a671 
  plugins/network-elements/internal-loadbalancer/test/org/apache/cloudstack/internallbvmmgr/InternalLBVMManagerTest.java a19a82e 
  server/src/com/cloud/configuration/Config.java e77f6ce 
  server/src/com/cloud/configuration/ConfigurationManager.java 1b99b63 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java 7e0bc25 
  server/src/com/cloud/network/NetworkManagerImpl.java 42430bc 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 7bd2864 
  server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 7a61978 
  server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java 36564d9 
  setup/db/db/schema-410to420.sql e9fa995 

Diff: https://reviews.apache.org/r/12109/diff/


Testing
-------

Tested on master.


Thanks,

bharat kumar

Re: Review Request 12109: HAProxy maxconn is not configurable

Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12109/#review22894
-----------------------------------------------------------



plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java
<https://reviews.apache.org/r/12109/#comment46640>

    Put a more meaningful message if you need to log.


- Abhinandan Prateek


On July 1, 2013, 3:55 p.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12109/
> -----------------------------------------------------------
> 
> (Updated July 1, 2013, 3:55 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy.
> 
> 
> Bugs: Cloudstack-2997
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Cloudstack-2997 HAProxy maxconn is not configurable
> https://issues.apache.org/jira/browse/CLOUDSTACK-2997
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/offering/NetworkOffering.java 5f522eb 
>   api/src/org/apache/cloudstack/api/ApiConstants.java b43f06c 
>   api/src/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java febb0c3 
>   api/src/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java ba685a9 
>   core/src/com/cloud/agent/api/routing/LoadBalancerConfigCommand.java 1c1fb91 
>   core/src/com/cloud/network/HAProxyConfigurator.java 29fdf4a 
>   engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java fae315b 
>   plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java b21e8f9 
>   plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java 2bdb28f 
>   plugins/network-elements/internal-loadbalancer/test/org/apache/cloudstack/internallbvmmgr/InternalLBVMManagerTest.java a19a82e 
>   server/src/com/cloud/configuration/Config.java 2b0ffaf 
>   server/src/com/cloud/configuration/ConfigurationManager.java 8db037b 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 97f0d33 
>   server/src/com/cloud/network/NetworkManagerImpl.java 8c2806a 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 7f3a88e 
>   server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 21b3590 
>   server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java 4a2c867 
>   setup/db/db/schema-410to420.sql 181f1cb 
> 
> Diff: https://reviews.apache.org/r/12109/diff/
> 
> 
> Testing
> -------
> 
> Tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 12109: HAProxy maxconn is not configurable

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12109/
-----------------------------------------------------------

(Updated July 1, 2013, 3:55 p.m.)


Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy.


Changes
-------

Jayapal (ping)


Bugs: Cloudstack-2997


Repository: cloudstack-git


Description
-------

Cloudstack-2997 HAProxy maxconn is not configurable
https://issues.apache.org/jira/browse/CLOUDSTACK-2997


Diffs
-----

  api/src/com/cloud/offering/NetworkOffering.java 5f522eb 
  api/src/org/apache/cloudstack/api/ApiConstants.java b43f06c 
  api/src/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java febb0c3 
  api/src/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java ba685a9 
  core/src/com/cloud/agent/api/routing/LoadBalancerConfigCommand.java 1c1fb91 
  core/src/com/cloud/network/HAProxyConfigurator.java 29fdf4a 
  engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java fae315b 
  plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java b21e8f9 
  plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java 2bdb28f 
  plugins/network-elements/internal-loadbalancer/test/org/apache/cloudstack/internallbvmmgr/InternalLBVMManagerTest.java a19a82e 
  server/src/com/cloud/configuration/Config.java 2b0ffaf 
  server/src/com/cloud/configuration/ConfigurationManager.java 8db037b 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java 97f0d33 
  server/src/com/cloud/network/NetworkManagerImpl.java 8c2806a 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 7f3a88e 
  server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 21b3590 
  server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java 4a2c867 
  setup/db/db/schema-410to420.sql 181f1cb 

Diff: https://reviews.apache.org/r/12109/diff/


Testing
-------

Tested on master.


Thanks,

bharat kumar