[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #475: [SUREFIRE-2025] Updated abstractions which helps associating systemProperties() with a test

[GitBox <gi...@apache.org>]

slawekjaranowski commented on a change in pull request #475:
URL: https://github.com/apache/maven-surefire/pull/475#discussion_r813866710



##########
File path: surefire-api/src/main/java/org/apache/maven/surefire/api/booter/MasterProcessChannelEncoder.java
##########
@@ -37,7 +38,7 @@
 
     void onJvmExit();
 
-    void systemProperties( Map<String, String> sysProps );
+    void systemProperties( Map<String, String> sysProps, RunMode runMode, Long testRunId );

Review comment:
       method name is not descriptive .... what does do .. read/write/verify properties? 
   Now new params - what for? 
   
   documentation is needed

##########
File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/EventChannelEncoder.java
##########
@@ -128,7 +128,7 @@ public void onJvmExit()
     }
 
     @Override
-    public void systemProperties( Map<String, String> sysProps )
+    public void systemProperties( Map<String, String> sysProps, RunMode rm, Long testRunId )

Review comment:
       we already have field with the same name and type `runMode`
   why not use filed from instance?

##########
File path: surefire-api/src/main/java/org/apache/maven/surefire/api/booter/ForkingRunListener.java
##########
@@ -68,7 +68,7 @@ public void testSetStarting( TestSetReportEntry report )
     @Override
     public void testSetCompleted( TestSetReportEntry report )
     {
-        target.systemProperties( report.getSystemProperties() );
+        target.systemProperties( report.getSystemProperties(), null, null );

Review comment:
       In this class we have filed `runMode` 
    - why not used here?
    - why is not propagated to `target`?

##########
File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/EventChannelEncoder.java
##########
@@ -128,7 +128,7 @@ public void onJvmExit()
     }
 
     @Override
-    public void systemProperties( Map<String, String> sysProps )
+    public void systemProperties( Map<String, String> sysProps, RunMode rm, Long testRunId )

Review comment:
       field `runMode` sometime is used ... sometime is overridden by method params in this class
   line: 389, 419  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org