You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/11/02 15:16:29 UTC
[GitHub] [netbeans] junichi11 opened a new pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
junichi11 opened a new pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296
- https://issues.apache.org/jira/browse/NETBEANS-3362
- Introduce StructureItem.InheritedItem interface
- Show inherited members on the navigator pane
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#issuecomment-957800775
@sdedic Could you please take a look at the CSL part (https://github.com/apache/netbeans/pull/3296/commits/90a2ea7ecc15c429e42dbe3be4183eec8d02ca8d)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 edited a comment on pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 edited a comment on pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#issuecomment-957800775
@sdedic Could you please take a look at the CSL part (https://github.com/apache/netbeans/pull/3296/commits/332762a8a794e7c9995e21c917b287a654fef051)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 edited a comment on pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 edited a comment on pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#issuecomment-957800775
@sdedic Could you please take a look at the CSL part (https://github.com/apache/netbeans/pull/3296/commits/332762a8a794e7c9995e21c917b287a654fef051)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#issuecomment-974598933
Will merge this. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 edited a comment on pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 edited a comment on pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#issuecomment-957800775
@sdedic Could you please take a look at the CSL part (https://github.com/apache/netbeans/pull/3296/commits/332762a8a794e7c9995e21c917b287a654fef051)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#discussion_r750050688
##########
File path: ide/csl.api/src/org/netbeans/modules/csl/api/StructureItem.java
##########
@@ -60,4 +60,15 @@
}
+ public interface InheritedItem extends StructureItem {
+
+ /**
+ * Check whether this StructureItem is an inherited item.
+ *
+ * @since 2.72.0
+ * @return {@code true} if it is an inherited item, otherwise
+ * {@code false}
+ */
+ boolean isInherited();
Review comment:
Now the API declares that the `StructureItem` is inherited. But does not give a clue where it is inherited from: if there was a `ElementHandle getDeclaringElement()` an abstract client (like a navigator) could use that info to e.g. group by parent. The item's own `ElementHandle` does not give parent info (but one could eventually use FileObject ?).
Just an idea now, when the API is being extended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 edited a comment on pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 edited a comment on pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#issuecomment-957800775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 merged pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 merged pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#discussion_r750050688
##########
File path: ide/csl.api/src/org/netbeans/modules/csl/api/StructureItem.java
##########
@@ -60,4 +60,15 @@
}
+ public interface InheritedItem extends StructureItem {
+
+ /**
+ * Check whether this StructureItem is an inherited item.
+ *
+ * @since 2.72.0
+ * @return {@code true} if it is an inherited item, otherwise
+ * {@code false}
+ */
+ boolean isInherited();
Review comment:
Now the API declares that the `StructureItem` is inherited. But does not give a clue where it is inherited from: if there was a `ElementHandle getDeclaringElement()` an abstract client (like a navigator) could use that info to e.g. group by parent. The item's own `ElementHandle` does not give parent info (but one could eventually use FileObject ?).
Just an idea given the API is going to be extended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#issuecomment-970895926
@tmysik Thank you for your review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#discussion_r751875558
##########
File path: ide/csl.api/src/org/netbeans/modules/csl/api/StructureItem.java
##########
@@ -60,4 +60,15 @@
}
+ public interface InheritedItem extends StructureItem {
+
+ /**
+ * Check whether this StructureItem is an inherited item.
+ *
+ * @since 2.72.0
+ * @return {@code true} if it is an inherited item, otherwise
+ * {@code false}
+ */
+ boolean isInherited();
Review comment:
@sdedic Fixed: https://github.com/apache/netbeans/compare/413de5540ab999605599cc876989b4fc97f2b5e7..89b415ba280687a03e03730f8737ae4d7967a2f1
Is this OK for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#discussion_r750783369
##########
File path: ide/csl.api/src/org/netbeans/modules/csl/api/StructureItem.java
##########
@@ -60,4 +60,15 @@
}
+ public interface InheritedItem extends StructureItem {
+
+ /**
+ * Check whether this StructureItem is an inherited item.
+ *
+ * @since 2.72.0
+ * @return {@code true} if it is an inherited item, otherwise
+ * {@code false}
+ */
+ boolean isInherited();
Review comment:
I see now. I'll try adding that method to `InheritedItem`. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 edited a comment on pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 edited a comment on pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#issuecomment-957800775
@sdedic Could you please take a look at the CSL part (the first commit)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#discussion_r748188236
##########
File path: ide/csl.api/src/org/netbeans/modules/csl/api/StructureItem.java
##########
@@ -60,4 +60,15 @@
}
+ public interface InheritedItem extends StructureItem {
+
+ /**
+ * Check whether this StructureItem is an inherited item.
+ *
+ * @since 2.72.0
+ * @return {@code true} if it is an inherited item, otherwise
+ * {@code false}
+ */
+ boolean isInherited();
Review comment:
Umm, I'm not sure what this means...what we should do... sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#issuecomment-967026920
@sdedic Don't worry about it :) I guessed you are so busy. Thank you for your review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#issuecomment-969471820
@JaroslavTulach @sdedic I've fixed the points that were pointed out. Please let me know if there are any problems. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 merged pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 merged pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#discussion_r741240081
##########
File path: ide/csl.api/src/org/netbeans/modules/csl/navigation/base/FiltersManager.java
##########
@@ -285,7 +291,18 @@ private void fireChange () {
// notify listener
lCopy.filterStateChanged(new ChangeEvent(FiltersManager.this));
}
-
+
+ @Override
+ public void removeNotify() {
+ // remember filter settings
+ if (null != filterStates) {
+ Preferences prefs = getPreferences();
+ for (String filterName : filterStates.keySet()) {
+ prefs.putBoolean(filterName, filterStates.get(filterName));
Review comment:
If the visible state should be persisted, then better save right after the toggle changes.
##########
File path: ide/csl.api/src/org/netbeans/modules/csl/api/StructureItem.java
##########
@@ -60,4 +60,15 @@
}
+ public interface InheritedItem extends StructureItem {
+
+ /**
+ * Check whether this StructureItem is an inherited item.
+ *
+ * @since 2.72.0
+ * @return {@code true} if it is an inherited item, otherwise
+ * {@code false}
+ */
+ boolean isInherited();
Review comment:
I'd suggest to extend this a little bit to provide e.g. `ElementHandle` (which should be equals/hashCode capable) to indicate declaring class/whatever of the inherited item. That could allow for future UI expansion like grouping stuff from the same source etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#issuecomment-960665728
Umm, there is a problem with the overriding method feature. Will investigate it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#issuecomment-961547207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#issuecomment-961547207
It should be OK now... https://github.com/apache/netbeans/compare/aee7893316efede889dee4bb5e32b5c58bea64bd..7f9aced23646e705fc10412da678b09d4169a2c1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 edited a comment on pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 edited a comment on pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#issuecomment-961547207
It should be OK now... https://github.com/apache/netbeans/compare/aee7893316efede889dee4bb5e32b5c58bea64bd..28c4692734c21860b277316982c0fd97988b6c3e.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 edited a comment on pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 edited a comment on pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#issuecomment-960665728
Umm, there are problems with other features(overriding method, bread crumb). Will investigate it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#discussion_r748100436
##########
File path: ide/csl.api/src/org/netbeans/modules/csl/editor/overridden/ComputeAnnotations.java
##########
@@ -127,6 +127,10 @@ public void run(Result result, SchedulerEvent event) {
while (!todo.isEmpty()) {
StructureItem i = todo.remove(0);
+ if (i instanceof StructureItem.InheritedItem
+ && ((StructureItem.InheritedItem) i).isInherited()) {
Review comment:
Rather than spreading these instance checks all over the place, there could be a helper method:
```java
public static boolean isInherited(StructureItem i) {
}
```
it could actually be in `StructureItem` interface itself now, when it is possible to have static methods in interfaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#issuecomment-957800775
@sdedic Could you please take a look at the CSL part (https://github.com/apache/netbeans/pull/3296/commits/90a2ea7ecc15c429e42dbe3be4183eec8d02ca8d)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#discussion_r748181549
##########
File path: ide/csl.api/src/org/netbeans/modules/csl/navigation/base/FiltersManager.java
##########
@@ -285,7 +291,18 @@ private void fireChange () {
// notify listener
lCopy.filterStateChanged(new ChangeEvent(FiltersManager.this));
}
-
+
+ @Override
+ public void removeNotify() {
+ // remember filter settings
+ if (null != filterStates) {
+ Preferences prefs = getPreferences();
+ for (String filterName : filterStates.keySet()) {
+ prefs.putBoolean(filterName, filterStates.get(filterName));
Review comment:
It is the same implementation as the navigator for Java. However, will change it. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#discussion_r748223902
##########
File path: ide/csl.api/src/org/netbeans/modules/csl/editor/overridden/ComputeAnnotations.java
##########
@@ -127,6 +127,10 @@ public void run(Result result, SchedulerEvent event) {
while (!todo.isEmpty()) {
StructureItem i = todo.remove(0);
+ if (i instanceof StructureItem.InheritedItem
+ && ((StructureItem.InheritedItem) i).isInherited()) {
Review comment:
Fixed: https://github.com/apache/netbeans/compare/28c4692734c21860b277316982c0fd97988b6c3e..413de5540ab999605599cc876989b4fc97f2b5e7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#issuecomment-969474464
@tmysik Could you please review the PHP part?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#discussion_r751875058
##########
File path: ide/csl.api/src/org/netbeans/modules/csl/api/StructureItem.java
##########
@@ -60,4 +75,25 @@
}
+ public interface InheritedItem extends StructureItem {
+
+ /**
+ * Check whether this StructureItem is an inherited item.
+ *
+ * @since 2.72.0
+ * @return {@code true} if it is an inherited item (a class doesn't
+ * override that member), otherwise {@code false} (a class declares it
+ * as an overriding member)
+ */
+ boolean isInherited();
+
+ /**
+ * Get the declaring element handle. e.g. class
+ *
+ * @since 2.72.0
+ * @return the declaring element handle of the inherited item
+ */
+ @NonNull
+ ElementHandle getDeclaringElement();
Review comment:
Generally, I suppose this doesn't return `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#discussion_r748224214
##########
File path: ide/csl.api/src/org/netbeans/modules/csl/navigation/base/FiltersManager.java
##########
@@ -285,7 +291,18 @@ private void fireChange () {
// notify listener
lCopy.filterStateChanged(new ChangeEvent(FiltersManager.this));
}
-
+
+ @Override
+ public void removeNotify() {
+ // remember filter settings
+ if (null != filterStates) {
+ Preferences prefs = getPreferences();
+ for (String filterName : filterStates.keySet()) {
+ prefs.putBoolean(filterName, filterStates.get(filterName));
Review comment:
Fixed: https://github.com/apache/netbeans/compare/28c4692734c21860b277316982c0fd97988b6c3e..413de5540ab999605599cc876989b4fc97f2b5e7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#issuecomment-966964615
Sigh. I had a PR review pending, but unpublished. @JaroslavTulach review's notification made me look & discover the draft. Sorry for the delay :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#discussion_r748106413
##########
File path: ide/csl.api/src/org/netbeans/modules/csl/editor/overridden/ComputeAnnotations.java
##########
@@ -127,6 +127,10 @@ public void run(Result result, SchedulerEvent event) {
while (!todo.isEmpty()) {
StructureItem i = todo.remove(0);
+ if (i instanceof StructureItem.InheritedItem
+ && ((StructureItem.InheritedItem) i).isInherited()) {
Review comment:
Thank you for your review! Will do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#issuecomment-974598933
Will merge this. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 edited a comment on pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 edited a comment on pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#issuecomment-957800775
@sdedic Could you please take a look at the CSL part (https://github.com/apache/netbeans/pull/3296/commits/332762a8a794e7c9995e21c917b287a654fef051)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#issuecomment-957800775
@sdedic Could you please take a look at the CSL part (https://github.com/apache/netbeans/pull/3296/commits/90a2ea7ecc15c429e42dbe3be4183eec8d02ca8d)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 edited a comment on pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane
Posted by GitBox <gi...@apache.org>.
junichi11 edited a comment on pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#issuecomment-957800775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists