You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Amogh Vasekar <am...@citrix.com> on 2014/05/20 02:09:46 UTC

Review Request 21673: Missing KVM mappings causes NPE

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21673/
-----------------------------------------------------------

Review request for cloudstack and Nitin Mehta.


Bugs: CLOUDSTACK-6671
    https://issues.apache.org/jira/browse/CLOUDSTACK-6671


Repository: cloudstack-git


Description
-------

Fixing NPE when a mapping is missing
Adding missing KVM mappings


Diffs
-----

  plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 620d7113f411c60729e176f093602dc364be74b9 
  server/src/com/cloud/hypervisor/KVMGuru.java 4225232064df1081e14f933837d001c1408012cf 

Diff: https://reviews.apache.org/r/21673/diff/


Testing
-------

Local testing with removing CentOS mapping and launch a VM. 


Thanks,

Amogh Vasekar


Re: Review Request 21673: Missing KVM mappings causes NPE

Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21673/#review43623
-----------------------------------------------------------

Ship it!


Ship It!

- Nitin Mehta


On May 20, 2014, 12:11 a.m., Amogh Vasekar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21673/
> -----------------------------------------------------------
> 
> (Updated May 20, 2014, 12:11 a.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-6671
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6671
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixing NPE when a mapping is missing
> Adding missing KVM mappings
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 620d7113f411c60729e176f093602dc364be74b9 
>   server/src/com/cloud/hypervisor/KVMGuru.java 4225232064df1081e14f933837d001c1408012cf 
>   setup/db/db/schema-430to440.sql 89db04a2e93e048e3b6fa088a9679d7d4daa29c7 
> 
> Diff: https://reviews.apache.org/r/21673/diff/
> 
> 
> Testing
> -------
> 
> Local testing with removing CentOS mapping and launch a VM. 
> 
> 
> Thanks,
> 
> Amogh Vasekar
> 
>


Re: Review Request 21673: Missing KVM mappings causes NPE

Posted by Amogh Vasekar <am...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21673/
-----------------------------------------------------------

(Updated May 20, 2014, 12:11 a.m.)


Review request for cloudstack and Nitin Mehta.


Bugs: CLOUDSTACK-6671
    https://issues.apache.org/jira/browse/CLOUDSTACK-6671


Repository: cloudstack-git


Description
-------

Fixing NPE when a mapping is missing
Adding missing KVM mappings


Diffs (updated)
-----

  plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 620d7113f411c60729e176f093602dc364be74b9 
  server/src/com/cloud/hypervisor/KVMGuru.java 4225232064df1081e14f933837d001c1408012cf 
  setup/db/db/schema-430to440.sql 89db04a2e93e048e3b6fa088a9679d7d4daa29c7 

Diff: https://reviews.apache.org/r/21673/diff/


Testing
-------

Local testing with removing CentOS mapping and launch a VM. 


Thanks,

Amogh Vasekar