[jira] [Commented] (FLINK-13926) `ProcessingTimeSessionWindows` and `EventTimeSessionWindows` should be generic

["Aljoscha Krettek (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-13926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17010639#comment-17010639 ] 

Aljoscha Krettek commented on FLINK-13926:
------------------------------------------

It's unfortunate that we have this discrepancy now but I think we cannot change the signatures of those classes because it might require changes in user code. I would like to ignore that unless absolutely necessary.

I'm closing this for now but please re-open if you feel strongly about it, you could then add it to this umbrella issue: FLINK-3957.

> `ProcessingTimeSessionWindows` and `EventTimeSessionWindows` should be generic 
> -------------------------------------------------------------------------------
>
>                 Key: FLINK-13926
>                 URL: https://issues.apache.org/jira/browse/FLINK-13926
>             Project: Flink
>          Issue Type: Improvement
>          Components: API / DataStream
>    Affects Versions: 1.9.0
>            Reporter: zhihao zhang
>            Priority: Major
>              Labels: pull-request-available, windows
>             Fix For: 2.0.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> `ProcessingTimeSessionWindows` and `EventTimeSessionWindows` should be generic just like `DynamicEventTimeSessionWindows` and `DynamicProcessingTimeSessionWindows`.
> now:
>  
> {code:java}
> public class ProcessingTimeSessionWindows extends MergingWindowAssigner<Object, TimeWindow> {}
> {code}
> proposal:
>  
> {code:java}
> public class ProcessingTimeSessionWindows<T> extends MergingWindowAssigner<T, TimeWindow> {}
> {code}
> If this ticket is ok to go, I would like to take it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)