You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pirk.apache.org by tellison <gi...@git.apache.org> on 2016/08/16 11:28:02 UTC
[GitHub] incubator-pirk pull request #64: Enhancements to partitioners, keyedHash, an...
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/64
Enhancements to partitioners, keyedHash, and prime generator.
- Convert last few remaining ArrayList return types on partitioners to
List interface, and deal with the flow through to calling methods.
- Enhance partition utils tests.
- Modify keyed hash to remove Maths.abs() call on string hashCode.
- Move constant value (\sqrt(2)) to static var in prime generator.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tellison/incubator-pirk ListInterface
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-pirk/pull/64.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #64
----
commit 6c3808fbf094393dea37a02b44037f7665b88ffb
Author: Tim Ellison <t....@gmail.com>
Date: 2016-08-16T10:45:13Z
Enhancements to partitioners, keyedHash, and prime generator.
- Convert last few remaining ArrayList return types on partitioners to
List interface, and deal with the flow through to calling methods.
- Enhance partition utils tests.
- Modify keyed hash to remove Maths.abs() call on string hashCode.
- Move constant value to static var in prime generator.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk pull request #64: Enhancements to partitioners, keyedHash, an...
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/64#discussion_r74921669
--- Diff: src/main/java/org/apache/pirk/schema/data/partitioner/PrimitiveTypePartitioner.java ---
@@ -90,12 +89,20 @@
}
/**
- * Method to form a BigInteger bit mask for the given partitionSize
- *
+ * Returns a <code>BigInteger</code> bit mask for the given partitionSize.
*/
public static BigInteger formBitMask(int partitionSize)
--- End diff --
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk pull request #64: Enhancements to partitioners, keyedHash, an...
Posted by tellison <gi...@git.apache.org>.
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/64#discussion_r74917596
--- Diff: src/main/java/org/apache/pirk/schema/data/partitioner/PrimitiveTypePartitioner.java ---
@@ -90,12 +89,20 @@
}
/**
- * Method to form a BigInteger bit mask for the given partitionSize
- *
+ * Returns a <code>BigInteger</code> bit mask for the given partitionSize.
*/
public static BigInteger formBitMask(int partitionSize)
--- End diff --
The method ```formBitMask``` only appears to be used in the tests. Can it be deleted?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #64: Enhancements to partitioners, keyedHash, and prime...
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/64
Lgtm +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk pull request #64: Enhancements to partitioners, keyedHash, an...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-pirk/pull/64
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk pull request #64: Enhancements to partitioners, keyedHash, an...
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/64#discussion_r74921656
--- Diff: src/main/java/org/apache/pirk/schema/data/partitioner/PrimitiveTypePartitioner.java ---
@@ -48,8 +48,7 @@
public static final String STRING = "string";
/**
- * Splits the given BigInteger into partitions given by the partitionSize
- *
+ * Splits the given BigInteger into partitions given by the partitionSize.
*/
public static List<BigInteger> partitionBits(BigInteger value, int partitionSize, BigInteger mask) throws PIRException
--- End diff --
Agree it shuld be deleted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #64: Enhancements to partitioners, keyedHash, and prime...
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/64
Merging this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk pull request #64: Enhancements to partitioners, keyedHash, an...
Posted by tellison <gi...@git.apache.org>.
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/64#discussion_r74917728
--- Diff: src/main/java/org/apache/pirk/schema/data/partitioner/PrimitiveTypePartitioner.java ---
@@ -48,8 +48,7 @@
public static final String STRING = "string";
/**
- * Splits the given BigInteger into partitions given by the partitionSize
- *
+ * Splits the given BigInteger into partitions given by the partitionSize.
*/
public static List<BigInteger> partitionBits(BigInteger value, int partitionSize, BigInteger mask) throws PIRException
--- End diff --
The method ```partitionBits``` only appears to be called from the tests. Can it be deleted?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---