You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/06/17 16:22:37 UTC

[GitHub] [druid] gianm commented on a diff in pull request #12669: Fix self-referential shape inspection in BaseExpressionColumnValueSelector.

gianm commented on code in PR #12669:
URL: https://github.com/apache/druid/pull/12669#discussion_r900302066


##########
processing/src/test/java/org/apache/druid/query/topn/TopNQueryRunnerTest.java:
##########
@@ -4541,6 +4541,79 @@ public void testFullOnTopNLongColumn()
     assertExpectedResults(expectedResults, query);
   }
 
+  @Test
+  public void testFullOnTopNLongVirtualColumn()

Review Comment:
   Yeah, it was an accident in the original version of the patch. I meant to add a new one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org