You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nitiraj Rathore <ni...@gmail.com> on 2017/03/01 10:23:55 UTC
Review Request 57198: HiveView2.0: Can not create a table with space
in column name with upload table feature
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57198/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
Bugs: AMBARI-20181
https://issues.apache.org/jira/browse/AMBARI-20181
Repository: ambari
Description
-------
added back ticks in the query
Diffs
-----
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnInfo.java 9f179d1
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/CreateTableQueryGenerator.java eab3a4b
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java 42cec0a
contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/CreateTableQueryGeneratorTest.java f5a9778
contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGeneratorSpecTest.groovy PRE-CREATION
Diff: https://reviews.apache.org/r/57198/diff/1/
Testing
-------
added InsertFromQueryGeneratorSpecTest.groovy test class
Thanks,
Nitiraj Rathore
Re: Review Request 57198: HiveView2.0: Can not create a table with
space in column name with upload table feature
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57198/
-----------------------------------------------------------
(Updated March 1, 2017, 6:16 p.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
Changes
-------
update patch to remove conflicts
Bugs: AMBARI-20181
https://issues.apache.org/jira/browse/AMBARI-20181
Repository: ambari
Description
-------
added back ticks in the query
Diffs (updated)
-----
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnInfo.java 9f179d1
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/CreateTableQueryGenerator.java eab3a4b
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java b544100
contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/CreateTableQueryGeneratorTest.java f5a9778
contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGeneratorSpecTest.groovy PRE-CREATION
Diff: https://reviews.apache.org/r/57198/diff/2/
Changes: https://reviews.apache.org/r/57198/diff/1-2/
Testing
-------
added InsertFromQueryGeneratorSpecTest.groovy test class
Thanks,
Nitiraj Rathore
Re: Review Request 57198: HiveView2.0: Can not create a table with
space in column name with upload table feature
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57198/#review167259
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On March 1, 2017, 10:23 a.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57198/
> -----------------------------------------------------------
>
> (Updated March 1, 2017, 10:23 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
>
>
> Bugs: AMBARI-20181
> https://issues.apache.org/jira/browse/AMBARI-20181
>
>
> Repository: ambari
>
>
> Description
> -------
>
> added back ticks in the query
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnInfo.java 9f179d1
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/CreateTableQueryGenerator.java eab3a4b
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java 42cec0a
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/CreateTableQueryGeneratorTest.java f5a9778
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGeneratorSpecTest.groovy PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57198/diff/1/
>
>
> Testing
> -------
>
> added InsertFromQueryGeneratorSpecTest.groovy test class
>
>
> Thanks,
>
> Nitiraj Rathore
>
>
Re: Review Request 57198: HiveView2.0: Can not create a table with
space in column name with upload table feature
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57198/#review167268
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On March 1, 2017, 10:23 a.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57198/
> -----------------------------------------------------------
>
> (Updated March 1, 2017, 10:23 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
>
>
> Bugs: AMBARI-20181
> https://issues.apache.org/jira/browse/AMBARI-20181
>
>
> Repository: ambari
>
>
> Description
> -------
>
> added back ticks in the query
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnInfo.java 9f179d1
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/CreateTableQueryGenerator.java eab3a4b
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java 42cec0a
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/CreateTableQueryGeneratorTest.java f5a9778
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGeneratorSpecTest.groovy PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57198/diff/1/
>
>
> Testing
> -------
>
> added InsertFromQueryGeneratorSpecTest.groovy test class
>
>
> Thanks,
>
> Nitiraj Rathore
>
>