You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "chennaji9 (via GitHub)" <gi...@apache.org> on 2026/10/09 11:51:31 UTC

[PR] [ISSUE #11315] fix(docs): correct broker log filename case in Deployment guides [rocketmq]

chennaji9 opened a new pull request, #11320:
URL: https://github.com/apache/rocketmq/pull/11320

   <!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
   
   ### Which Issue(s) This PR Fixes
   
   Fixes #11315
   
   ### Brief Description
   
   Both the English and Chinese quick-start deployment guides tell users to verify broker startup with `tail -f ~/logs/rocketmqlogs/Broker.log`. The broker's logback configuration (`broker/src/main/resources/rmq.broker.logback.xml:60`) writes `broker.log` (lowercase). On case-sensitive filesystems — the platforms the `tail -f` instruction targets — the documented command fails with "No such file or directory" right after a successful broker start, sending new users hunting for a nonexistent startup problem.
   
   Both pages (`docs/en/Deployment.md`, `docs/cn/Deployment.md`, lines 29 and 33 in each) now reference `broker.log`. Four line changes across two files.
   
   ### How Did You Test This Change?
   
   Documentation-only change, verified statically:
   - Filename confirmed from the broker logging config: `<file>...rocketmqlogs...broker.log</file>` (`rmq.broker.logback.xml:60`) at the PR base commit.
   - `grep -rn 'Broker.log' docs/ distribution/` after the change: no remaining occurrences of the wrong-case name.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #11315] fix(docs): correct broker log filename case in Deployment guides [rocketmq]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11320:
URL: https://github.com/apache/rocketmq/pull/11320#issuecomment-6081073082

   ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/11320?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 49.67%. Comparing base ([`9ea2ccd`](https://app.codecov.io/gh/apache/rocketmq/commit/9ea2ccdc2b41445aee5e177e14e501d606f5a1ed?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`615a4ba`](https://app.codecov.io/gh/apache/rocketmq/commit/615a4bac9762ebb6eddbb4e8e11db3fd5be54678?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop   #11320      +/-   ##
   =============================================
   - Coverage      49.68%   49.67%   -0.01%     
   + Complexity     14331    14329       -2     
   =============================================
     Files           1390     1390              
     Lines         103246   103246              
     Branches       13502    13502              
   =============================================
   - Hits           51298    51288      -10     
   - Misses         45743    45755      +12     
   + Partials        6205     6203       -2     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/rocketmq/pull/11320?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #11315] fix(docs): correct broker log filename case in Deployment guides [rocketmq]

Posted by "chennaji9 (via GitHub)" <gi...@apache.org>.
chennaji9 commented on PR #11320:
URL: https://github.com/apache/rocketmq/pull/11320#issuecomment-6259705923

   Hi @RongtongJin, gentle follow-up on this one — it has been sitting for quite a while now. Everything (local tests + CI) is green, and the change is deliberately minimal (correct broker log filename case in Deployment guides). A review would be really appreciated whenever you have time, and merging would be great if it looks reasonable. Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org