You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/03 00:48:10 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #28097: logging poke info when external dag is not none and task_id and task_ids are none

uranusjr commented on code in PR #28097:
URL: https://github.com/apache/airflow/pull/28097#discussion_r1060221241


##########
airflow/sensors/external_task.py:
##########
@@ -140,21 +140,30 @@ def __init__(
                 f"`{self.allowed_states}` and failed states `{self.failed_states}`"
             )
 
-        if external_task_id is not None and external_task_ids is not None:
+        if external_task_id and external_task_ids:

Review Comment:
   Does `external_task_ids=[]` make sense? If it does, we’d want to keep using `is not None`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org