You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2021/04/12 08:00:10 UTC

[GitHub] [parquet-mr] martin-g opened a new pull request #890: PARQUET-2023 Do not pipe the mvn output to pv

martin-g opened a new pull request #890:
URL: https://github.com/apache/parquet-mr/pull/890


   Piping to pv looses the exit status of mvn and the builds never fail
   
   Run mvn in quiet mode to prevent Travis error because of too much output
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   https://issues.apache.org/jira/browse/PARQUET-2023
   
   ### Tests
   
   No modifications to the source code. Only to the CI config.
   
   ### Commits
   
   - [ X ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   No new functionality!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] gszadovszky commented on pull request #890: PARQUET-2023 Do not pipe the mvn output to pv

Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #890:
URL: https://github.com/apache/parquet-mr/pull/890#issuecomment-818533729


   @martin-g, it sounds great. If you want to invest more in this I am happy to review it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] martin-g edited a comment on pull request #890: PARQUET-2023 Do not pipe the mvn output to pv

Posted by GitBox <gi...@apache.org>.
martin-g edited a comment on pull request #890:
URL: https://github.com/apache/parquet-mr/pull/890#issuecomment-818532217


   I have (maybe?!) a better solution:
   
   `mvn clean ... -Dorg.slf4j.simpleLogger.logFile=maven.log`
   
   This will write all the output to `./maven.log`. In combination with `travis_wait` and `after_failure` we could achieve what you wanted to do with `pv`. What do you think ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] martin-g edited a comment on pull request #890: PARQUET-2023 Do not pipe the mvn output to pv

Posted by GitBox <gi...@apache.org>.
martin-g edited a comment on pull request #890:
URL: https://github.com/apache/parquet-mr/pull/890#issuecomment-818532217


   I have (maybe?!) a better solution:
   
   `mvn clean ... -Dorg.slf4j.simpleLogger.logFile=maven.log`
   
   This will write all the output to `./maven.log`. In combination with `travis_wait` and `after_failure` we could achieve what you wanted to do with `pv`. What do you think ?
   
   Another useful setting is `org.slf4j.simpleLogger.defaultLogLevel` if later we decide to reduce the logs to warns and errors. All settings could be found [here](http://www.slf4j.org/api/org/slf4j/impl/SimpleLogger.html)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] martin-g commented on pull request #890: PARQUET-2023 Do not pipe the mvn output to pv

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #890:
URL: https://github.com/apache/parquet-mr/pull/890#issuecomment-818532217


   I have (maybe?!) a better solution:
   
   `mvn clean ... -Dorg.slf4j.simpleLogger.logFile=simple.log`
   
   This will write all the output to ./simple.log. In combination with `travis_wait` and `after_failure` we could achieve what you wanted to do with `pv`. What do you think ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] gszadovszky merged pull request #890: PARQUET-2023 Do not pipe the mvn output to pv

Posted by GitBox <gi...@apache.org>.
gszadovszky merged pull request #890:
URL: https://github.com/apache/parquet-mr/pull/890


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] martin-g commented on pull request #890: PARQUET-2023 Do not pipe the mvn output to pv

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #890:
URL: https://github.com/apache/parquet-mr/pull/890#issuecomment-818699166


   No problem!
   Just ping me if you think I could be in help with something else!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] martin-g commented on pull request #890: PARQUET-2023 Do not pipe the mvn output to pv

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #890:
URL: https://github.com/apache/parquet-mr/pull/890#issuecomment-818534435


   > If you want to invest more in this I am happy to review it.
   
   Good! I will update the PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org