You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/28 11:12:35 UTC

[GitHub] [pulsar] Jason918 opened a new pull request, #16848: [Branch 2.7] Fix validateGlobalNamespaceOwnership wrap exception issue.

Jason918 opened a new pull request, #16848:
URL: https://github.com/apache/pulsar/pull/16848

   Cherry pick #14269 to branch 2.7
   
   ### Motivation
   When Rest API call `AdminResource#validateGlobalNamespaceOwnership`, broker will execute `PulsarWebResource#checkLocalOrGetPeerReplicationCluster`.
   In `PulsarWebResource#checkLocalOrGetPeerReplicationCluster`:
   https://github.com/apache/pulsar/blob/6d717a08ef8cfcac032caee06105285594baf09f/pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java#L773-L802
   
   Line 780, 794, and 801 has thrown RestException.
   But `validateGlobalNamespaceOwnership ` has wrapped the exception :
   https://github.com/apache/pulsar/blob/6d717a08ef8cfcac032caee06105285594baf09f/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java#L202-L216
   
   This could make the user confused that the log printed is not matched with the REST API.
   
   
   ### Modification
   
   - Add a relative test.
   
   ### Documentation
     
   - [x] `no-need-doc` 
     
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Technoboy- merged pull request #16848: [Branch 2.7] Fix validateGlobalNamespaceOwnership wrap exception issue.

Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #16848:
URL: https://github.com/apache/pulsar/pull/16848


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org