You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Jason Altekruse <al...@gmail.com> on 2014/01/04 00:51:01 UTC

Review Request 16628: Drill 238/342

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16628/
-----------------------------------------------------------

Review request for drill and Jacques Nadeau.


Repository: drill-git


Description
-------

Updated changes for outstanding patch for Drill 238, and error with reading nullable columns in parquet. Also included parquet test reorganization and consolidation. Patch is based on the changes done for Drill 315, review request is linked in the "Depends on" field above.


Diffs
-----

  exec/java-exec/src/test/java/org/apache/drill/exec/store/CachedSingleFileSystem.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/ParquetRecordReaderTest.java fb357c5 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/TestOutputMutator.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/FieldInfo.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetRecordReaderTest.java ab29a9f 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetResultListener.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetTestProperties.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestFileGenerator.java d2c95fe 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/WrapAroundCounter.java PRE-CREATION 

Diff: https://reviews.apache.org/r/16628/diff/


Testing
-------


Thanks,

Jason Altekruse


Re: Review Request 16628: Drill 238/342

Posted by Jason Altekruse <al...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16628/
-----------------------------------------------------------

(Updated March 10, 2014, 9:44 p.m.)


Review request for drill and Jacques Nadeau.


Changes
-------

rebased on master, commit 08a9a90d9f.


Repository: drill-git


Description
-------

Updated changes for outstanding patch for Drill 238, and error with reading nullable columns in parquet. Also included parquet test reorganization and consolidation. Patch is based on the changes done for Drill 315, review request is linked in the "Depends on" field above.


Diffs (updated)
-----

  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetRecordReaderTest.java 9e999e3 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetRecordReaderTest2.java 2ab12cb 
  exec/java-exec/src/test/resources/parquet/parquet_nullable.json PRE-CREATION 
  exec/java-exec/src/test/resources/parquet/parquet_nullable_varlen.json PRE-CREATION 
  exec/java-exec/src/test/resources/parquet/parquet_selective_column_read.json PRE-CREATION 
  exec/java-exec/src/test/resources/parquet_nullable.json 5822bdb 
  exec/java-exec/src/test/resources/parquet_nullable_varlen.json c21beec 
  exec/java-exec/src/test/resources/parquet_scan_screen.json 3b3f86a 
  exec/java-exec/src/test/resources/parquet_scan_screen_read_entry_replace.json ab11a5f 
  exec/java-exec/src/test/resources/parquet_scan_union_screen_physical.json 954082c 
  exec/java-exec/src/test/resources/parquet_selective_column_read.json 515affc 
  pom.xml 1bb58c0 

Diff: https://reviews.apache.org/r/16628/diff/


Testing
-------


Thanks,

Jason Altekruse


Re: Review Request 16628: Drill 238/342

Posted by Jason Altekruse <al...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16628/
-----------------------------------------------------------

(Updated Jan. 16, 2014, 5:05 p.m.)


Review request for drill and Jacques Nadeau.


Changes
-------

Rebased on changes to parent patch.


Repository: drill-git


Description
-------

Updated changes for outstanding patch for Drill 238, and error with reading nullable columns in parquet. Also included parquet test reorganization and consolidation. Patch is based on the changes done for Drill 315, review request is linked in the "Depends on" field above.


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/store/json/JSONRecordReader.java 49aea22 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/VarLenBinaryReader.java 276a4df 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/CachedSingleFileSystem.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/ParquetRecordReaderTest.java 733cb1d 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/TestOutputMutator.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/FieldInfo.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetRecordReaderTest.java ab29a9f 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetResultListener.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetTestProperties.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestFileGenerator.java d2c95fe 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/WrapAroundCounter.java PRE-CREATION 

Diff: https://reviews.apache.org/r/16628/diff/


Testing
-------


Thanks,

Jason Altekruse