You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2024/06/18 23:41:32 UTC
[Impala-ASF-CR] IMPALA-13166: Improve lookup of existing slot descriptors
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21531
Change subject: IMPALA-13166: Improve lookup of existing slot descriptors
......................................................................
IMPALA-13166: Improve lookup of existing slot descriptors
Improves lookup for existing SlotDescriptors created by another Analyzer
by maintaining a map of Path to SlotDescriptor in TupleDescriptor. Only
adds entries that are also inserted into slotPathMap_.
Moves expensive lower-case slot path precondition to happen only when
adding new slot descriptors.
Speeds up PlannerTest#testManyExpressionPerformance by 1-2s (5-10%) in
local testing.
Change-Id: Id904ee8a641fb06ebca95b53ea29e78d120a2288
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java
2 files changed, 27 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/21531/1
--
To view, visit http://gerrit.cloudera.org:8080/21531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id904ee8a641fb06ebca95b53ea29e78d120a2288
Gerrit-Change-Number: 21531
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-13166: Improve lookup of existing slot descriptors
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21531 )
Change subject: IMPALA-13166: Improve lookup of existing slot descriptors
......................................................................
IMPALA-13166: Improve lookup of existing slot descriptors
Improves lookup for existing SlotDescriptors created by another Analyzer
by maintaining a map of Path to SlotDescriptor in TupleDescriptor. Only
adds entries that are also inserted into slotPathMap_.
Moves expensive lower-case slot path precondition to happen only when
adding new slot descriptors.
Speeds up PlannerTest#testManyExpressionPerformance by 1-2s (5-10%) in
local testing.
Change-Id: Id904ee8a641fb06ebca95b53ea29e78d120a2288
Reviewed-on: http://gerrit.cloudera.org:8080/21531
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java
2 files changed, 27 insertions(+), 17 deletions(-)
Approvals:
Michael Smith: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id904ee8a641fb06ebca95b53ea29e78d120a2288
Gerrit-Change-Number: 21531
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
[Impala-ASF-CR] IMPALA-13166: Improve lookup of existing slot descriptors
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/21531 )
Change subject: IMPALA-13166: Improve lookup of existing slot descriptors
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id904ee8a641fb06ebca95b53ea29e78d120a2288
Gerrit-Change-Number: 21531
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Sat, 10 Jan 2026 13:56:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13166: Improve lookup of existing slot descriptors
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21531 )
Change subject: IMPALA-13166: Improve lookup of existing slot descriptors
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21531/1/fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java
File fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java:
http://gerrit.cloudera.org:8080/#/c/21531/1/fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java@84
PS1, Line 84: new HashMap<>()
Not sure what is the memory impact is by adding this field.
Is it worth to specify initialCapacity =1 ?
--
To view, visit http://gerrit.cloudera.org:8080/21531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id904ee8a641fb06ebca95b53ea29e78d120a2288
Gerrit-Change-Number: 21531
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jul 2024 18:51:42 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13166: Improve lookup of existing slot descriptors
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21531 )
Change subject: IMPALA-13166: Improve lookup of existing slot descriptors
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16392/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id904ee8a641fb06ebca95b53ea29e78d120a2288
Gerrit-Change-Number: 21531
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Jun 2024 00:05:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13166: Improve lookup of existing slot descriptors
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21531 )
Change subject: IMPALA-13166: Improve lookup of existing slot descriptors
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21531/1/fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java
File fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java:
http://gerrit.cloudera.org:8080/#/c/21531/1/fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java@84
PS1, Line 84: new HashMap<>()
> Not sure what is the memory impact is by adding this field.
In most cases slotByPath_ will have the same size as slots_. It won't for collection types.
--
To view, visit http://gerrit.cloudera.org:8080/21531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id904ee8a641fb06ebca95b53ea29e78d120a2288
Gerrit-Change-Number: 21531
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jul 2024 20:59:27 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13166: Improve lookup of existing slot descriptors
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21531 )
Change subject: IMPALA-13166: Improve lookup of existing slot descriptors
......................................................................
Patch Set 6: Code-Review+2
Carry +2 for rebase.
--
To view, visit http://gerrit.cloudera.org:8080/21531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id904ee8a641fb06ebca95b53ea29e78d120a2288
Gerrit-Change-Number: 21531
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Thu, 22 Jan 2026 17:05:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13166: Improve lookup of existing slot descriptors
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21531 )
Change subject: IMPALA-13166: Improve lookup of existing slot descriptors
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id904ee8a641fb06ebca95b53ea29e78d120a2288
Gerrit-Change-Number: 21531
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Thu, 22 Jan 2026 22:48:37 +0000
Gerrit-HasComments: No