You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/19 14:26:41 UTC

[GitHub] [flink] zentol opened a new pull request #12251: [FLINK-17812][dist] Bundle reporters in plugins/ directory

zentol opened a new pull request #12251:
URL: https://github.com/apache/flink/pull/12251


   With this PR all reporters are bundled in the plugins/ directory, instead of opt/. This means that all reporters are available by default, and it is highly unlikely that users copy them into lib/, where they could cause dependency clashes.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12251: [FLINK-17812][dist] Bundle reporters in plugins/ directory

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12251:
URL: https://github.com/apache/flink/pull/12251#issuecomment-630856669


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 0d41ed74bba8eff48da9000c6c3077bbdac1b4c5 (Tue May 19 14:28:44 UTC 2020)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12251: [FLINK-17812][dist] Bundle reporters in plugins/ directory

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12251:
URL: https://github.com/apache/flink/pull/12251#issuecomment-630873924


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0d41ed74bba8eff48da9000c6c3077bbdac1b4c5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1870",
       "triggerID" : "0d41ed74bba8eff48da9000c6c3077bbdac1b4c5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0d41ed74bba8eff48da9000c6c3077bbdac1b4c5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1870) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #12251: [FLINK-17812][dist] Bundle reporters in plugins/ directory

Posted by GitBox <gi...@apache.org>.
zentol merged pull request #12251:
URL: https://github.com/apache/flink/pull/12251


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12251: [FLINK-17812][dist] Bundle reporters in plugins/ directory

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12251:
URL: https://github.com/apache/flink/pull/12251#issuecomment-630873924


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0d41ed74bba8eff48da9000c6c3077bbdac1b4c5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1870",
       "triggerID" : "0d41ed74bba8eff48da9000c6c3077bbdac1b4c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1111bacba6355dcb9a32e999acd296ae8f4e0dab",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2208",
       "triggerID" : "1111bacba6355dcb9a32e999acd296ae8f4e0dab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0f34b588e9466b5673bec551e9e1050a9ac4e37e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2265",
       "triggerID" : "0f34b588e9466b5673bec551e9e1050a9ac4e37e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1111bacba6355dcb9a32e999acd296ae8f4e0dab Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2208) 
   * 0f34b588e9466b5673bec551e9e1050a9ac4e37e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2265) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12251: [FLINK-17812][dist] Bundle reporters in plugins/ directory

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12251:
URL: https://github.com/apache/flink/pull/12251#issuecomment-630873924


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0d41ed74bba8eff48da9000c6c3077bbdac1b4c5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1870",
       "triggerID" : "0d41ed74bba8eff48da9000c6c3077bbdac1b4c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1111bacba6355dcb9a32e999acd296ae8f4e0dab",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2208",
       "triggerID" : "1111bacba6355dcb9a32e999acd296ae8f4e0dab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0f34b588e9466b5673bec551e9e1050a9ac4e37e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0f34b588e9466b5673bec551e9e1050a9ac4e37e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1111bacba6355dcb9a32e999acd296ae8f4e0dab Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2208) 
   * 0f34b588e9466b5673bec551e9e1050a9ac4e37e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12251: [FLINK-17812][dist] Bundle reporters in plugins/ directory

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12251:
URL: https://github.com/apache/flink/pull/12251#issuecomment-630873924






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger commented on pull request #12251: [FLINK-17812][dist] Bundle reporters in plugins/ directory

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #12251:
URL: https://github.com/apache/flink/pull/12251#issuecomment-634005552


   Note, this change is breaking the e2e tests: https://dev.azure.com/georgeryan1322/Flink/_build/results?buildId=326&view=logs&j=1f3ed471-1849-5d3c-a34c-19792af4ad16&t=2f5b54d0-1d28-5b01-d344-aa50ffe0cdf8


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12251: [FLINK-17812][dist] Bundle reporters in plugins/ directory

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12251:
URL: https://github.com/apache/flink/pull/12251#issuecomment-630873924


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0d41ed74bba8eff48da9000c6c3077bbdac1b4c5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0d41ed74bba8eff48da9000c6c3077bbdac1b4c5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0d41ed74bba8eff48da9000c6c3077bbdac1b4c5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12251: [FLINK-17812][dist] Bundle reporters in plugins/ directory

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12251:
URL: https://github.com/apache/flink/pull/12251#issuecomment-630873924


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0d41ed74bba8eff48da9000c6c3077bbdac1b4c5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1870",
       "triggerID" : "0d41ed74bba8eff48da9000c6c3077bbdac1b4c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1111bacba6355dcb9a32e999acd296ae8f4e0dab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2208",
       "triggerID" : "1111bacba6355dcb9a32e999acd296ae8f4e0dab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0f34b588e9466b5673bec551e9e1050a9ac4e37e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2265",
       "triggerID" : "0f34b588e9466b5673bec551e9e1050a9ac4e37e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0f34b588e9466b5673bec551e9e1050a9ac4e37e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2265) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12251: [FLINK-17812][dist] Bundle reporters in plugins/ directory

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12251:
URL: https://github.com/apache/flink/pull/12251#issuecomment-630873924


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0d41ed74bba8eff48da9000c6c3077bbdac1b4c5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1870",
       "triggerID" : "0d41ed74bba8eff48da9000c6c3077bbdac1b4c5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0d41ed74bba8eff48da9000c6c3077bbdac1b4c5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1870) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org