You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Simon (Updated) (JIRA)" <ji...@apache.org> on 2011/12/16 22:02:30 UTC

[jira] [Updated] (SSHD-153) Improve handling of SSH_MSG_CHANNEL_WINDOW_ADJUST message

     [ https://issues.apache.org/jira/browse/SSHD-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon updated SSHD-153:
-----------------------

    Attachment: ssh_window_adjustment_patch.diff
    
> Improve handling of SSH_MSG_CHANNEL_WINDOW_ADJUST message
> ---------------------------------------------------------
>
>                 Key: SSHD-153
>                 URL: https://issues.apache.org/jira/browse/SSHD-153
>             Project: MINA SSHD
>          Issue Type: Improvement
>         Environment: All
>            Reporter: Simon
>            Priority: Trivial
>              Labels: patch
>             Fix For: 0.7.0
>
>         Attachments: ssh_window_adjustment_patch.diff
>
>
> I posted about this issue in the users mailing list...
> The consumeAndCheck() method of channel/Window.java is used to enlarge the receive window of channel. While tracing a libssh2 based application with tracing enabled talking to a SSHD-Core Java app, I found out it sends too many of these adjustment message. It was sending one every 3 packet size which is quite too much considering the default packet size of 32kb. 
> The RFC 4254 is unclear about proper handling but sending one when the current window size reaches half of its maximum look common. This is what OpenSSH
> I've attached a patch taken from the trunk http://svn.apache.org/repos/asf/mina/sshd/trunk

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira