You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/10/24 19:37:31 UTC
[GitHub] [hadoop] snmvaughan commented on a diff in pull request #4835: HDFS-16740. Mini cluster test flakiness
snmvaughan commented on code in PR #4835:
URL: https://github.com/apache/hadoop/pull/4835#discussion_r1003680369
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/MiniJournalCluster.java:
##########
@@ -64,7 +65,17 @@ public static class Builder {
public Builder(Configuration conf) {
this.conf = conf;
}
-
+
+ public Builder(Configuration conf, TemporaryFolder baseDir) {
Review Comment:
I can remove the JUnit dependency, but I was thinking it would be useful to differentiate between those instances that had been updated to use the TemporaryFolder handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org