You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/06 07:13:22 UTC
[GitHub] [incubator-inlong] dockerzhang commented on a diff in pull request #4522: [INLONG-4520][Audit] Audit-proxy supports Pulsar authenticate
dockerzhang commented on code in PR #4522:
URL: https://github.com/apache/incubator-inlong/pull/4522#discussion_r889881739
##########
inlong-audit/audit-proxy/src/main/java/org/apache/inlong/audit/sink/pulsar/PulsarClientService.java:
##########
@@ -76,11 +82,14 @@ public class PulsarClientService {
public ConcurrentHashMap<String, Producer> producerInfoMap;
public PulsarClient pulsarClient;
public String pulsarServerUrl;
+ public boolean pulsarEnableAuth = true;
Review Comment:
pulsarEnableTokenAuth = false
##########
inlong-audit/conf/audit-proxy-pulsar.conf:
##########
@@ -61,6 +61,8 @@ agent1.sinks.pulsar-sink-msg1.channel = ch-msg1
agent1.sinks.pulsar-sink-msg1.type = org.apache.inlong.audit.sink.PulsarSink
agent1.sinks.pulsar-sink-msg1.pulsar_server_url = pulsar://localhost:6650
agent1.sinks.pulsar-sink-msg1.topic = persistent://public/default/inlong-audit
+agent1.sinks.pulsar-sink-msg1.enable_auth = true
+agent1.sinks.pulsar-sink-msg1.auth_token = token
Review Comment:
the default value change to an empty value.
##########
inlong-audit/conf/audit-proxy-pulsar.conf:
##########
@@ -77,6 +79,8 @@ agent1.sinks.pulsar-sink-msg2.channel = ch-msg2
agent1.sinks.pulsar-sink-msg2.type = org.apache.inlong.audit.sink.PulsarSink
agent1.sinks.pulsar-sink-msg2.pulsar_server_url = pulsar://localhost:6650
agent1.sinks.pulsar-sink-msg2.topic = persistent://public/default/inlong-audit
+agent1.sinks.pulsar-sink-msg1.enable_auth = true
Review Comment:
ditto
##########
inlong-audit/audit-proxy/src/main/java/org/apache/inlong/audit/sink/pulsar/PulsarClientService.java:
##########
@@ -76,11 +82,14 @@ public class PulsarClientService {
public ConcurrentHashMap<String, Producer> producerInfoMap;
public PulsarClient pulsarClient;
public String pulsarServerUrl;
+ public boolean pulsarEnableAuth = true;
+ public String pulsarAuthToken;
Review Comment:
pulsarTokenAuth
##########
inlong-audit/conf/audit-proxy-pulsar.conf:
##########
@@ -77,6 +79,8 @@ agent1.sinks.pulsar-sink-msg2.channel = ch-msg2
agent1.sinks.pulsar-sink-msg2.type = org.apache.inlong.audit.sink.PulsarSink
agent1.sinks.pulsar-sink-msg2.pulsar_server_url = pulsar://localhost:6650
agent1.sinks.pulsar-sink-msg2.topic = persistent://public/default/inlong-audit
+agent1.sinks.pulsar-sink-msg1.enable_auth = true
+agent1.sinks.pulsar-sink-msg1.auth_token = token
Review Comment:
ditto
##########
inlong-audit/conf/audit-proxy-pulsar.conf:
##########
@@ -61,6 +61,8 @@ agent1.sinks.pulsar-sink-msg1.channel = ch-msg1
agent1.sinks.pulsar-sink-msg1.type = org.apache.inlong.audit.sink.PulsarSink
agent1.sinks.pulsar-sink-msg1.pulsar_server_url = pulsar://localhost:6650
agent1.sinks.pulsar-sink-msg1.topic = persistent://public/default/inlong-audit
+agent1.sinks.pulsar-sink-msg1.enable_auth = true
Review Comment:
the default value change to false may be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org