You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Santhosh Edukulla <sa...@citrix.com> on 2014/05/12 13:03:33 UTC
Review Request 21199: Added fix for CLOUDSTACK-6627
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21199/
-----------------------------------------------------------
Review request for cloudstack and Koushik Das.
Bugs: CLOUDSTACK-6627
https://issues.apache.org/jira/browse/CLOUDSTACK-6627
Repository: cloudstack-git
Description
-------
1. Added fix for CLOUDSTACK-6627. Instead of verifying for failed state, it should verify for exception. Test Case is now passing with change.
Diffs
-----
test/integration/smoke/test_pvlan.py a1c146b
Diff: https://reviews.apache.org/r/21199/diff/
Testing
-------
test_create_pvlan_network (integration.smoke.test_pvlan.TestPVLAN) ... === TestName: test_create_pvlan_network | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 6.542s
OK
Thanks,
Santhosh Edukulla
Re: Review Request 21199: Added fix for CLOUDSTACK-6627
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21199/#review42688
-----------------------------------------------------------
Ship it!
Ship It!
- daan Hoogland
On May 12, 2014, 11:04 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21199/
> -----------------------------------------------------------
>
> (Updated May 12, 2014, 11:04 a.m.)
>
>
> Review request for cloudstack and daan Hoogland.
>
>
> Bugs: CLOUDSTACK-6627
> https://issues.apache.org/jira/browse/CLOUDSTACK-6627
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Added fix for CLOUDSTACK-6627. Instead of verifying for failed state, it should verify for exception. Test Case is now passing with change.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_pvlan.py a1c146b
>
> Diff: https://reviews.apache.org/r/21199/diff/
>
>
> Testing
> -------
>
> test_create_pvlan_network (integration.smoke.test_pvlan.TestPVLAN) ... === TestName: test_create_pvlan_network | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 6.542s
>
> OK
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 21199: Added fix for CLOUDSTACK-6627
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21199/#review42685
-----------------------------------------------------------
Commit afd9d4e7567007604e15761a33ce9314149f7e21 in cloudstack's branch refs/heads/4.4-forward from santhosh
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=afd9d4e ]
CLOUDSTACK-6627 catch exception instead of checking response
Signed-off-by: santhosh <sa...@gmail.com>
Signed-off-by: Daan Hoogland <da...@onecht.net>
- ASF Subversion and Git Services
On May 12, 2014, 11:04 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21199/
> -----------------------------------------------------------
>
> (Updated May 12, 2014, 11:04 a.m.)
>
>
> Review request for cloudstack and daan Hoogland.
>
>
> Bugs: CLOUDSTACK-6627
> https://issues.apache.org/jira/browse/CLOUDSTACK-6627
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Added fix for CLOUDSTACK-6627. Instead of verifying for failed state, it should verify for exception. Test Case is now passing with change.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_pvlan.py a1c146b
>
> Diff: https://reviews.apache.org/r/21199/diff/
>
>
> Testing
> -------
>
> test_create_pvlan_network (integration.smoke.test_pvlan.TestPVLAN) ... === TestName: test_create_pvlan_network | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 6.542s
>
> OK
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 21199: Added fix for CLOUDSTACK-6627
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21199/#review42684
-----------------------------------------------------------
Commit f03e8a6f72fae83670359845c8284428a91e1bb4 in cloudstack's branch refs/heads/master from santhosh
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f03e8a6 ]
CLOUDSTACK-6627 catch exception instead of checking response
Signed-off-by: santhosh <sa...@gmail.com>
Signed-off-by: Daan Hoogland <da...@onecht.net>
- ASF Subversion and Git Services
On May 12, 2014, 11:04 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21199/
> -----------------------------------------------------------
>
> (Updated May 12, 2014, 11:04 a.m.)
>
>
> Review request for cloudstack and daan Hoogland.
>
>
> Bugs: CLOUDSTACK-6627
> https://issues.apache.org/jira/browse/CLOUDSTACK-6627
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Added fix for CLOUDSTACK-6627. Instead of verifying for failed state, it should verify for exception. Test Case is now passing with change.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_pvlan.py a1c146b
>
> Diff: https://reviews.apache.org/r/21199/diff/
>
>
> Testing
> -------
>
> test_create_pvlan_network (integration.smoke.test_pvlan.TestPVLAN) ... === TestName: test_create_pvlan_network | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 6.542s
>
> OK
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 21199: Added fix for CLOUDSTACK-6627
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21199/
-----------------------------------------------------------
(Updated May 12, 2014, 11:04 a.m.)
Review request for cloudstack and daan Hoogland.
Bugs: CLOUDSTACK-6627
https://issues.apache.org/jira/browse/CLOUDSTACK-6627
Repository: cloudstack-git
Description
-------
1. Added fix for CLOUDSTACK-6627. Instead of verifying for failed state, it should verify for exception. Test Case is now passing with change.
Diffs
-----
test/integration/smoke/test_pvlan.py a1c146b
Diff: https://reviews.apache.org/r/21199/diff/
Testing
-------
test_create_pvlan_network (integration.smoke.test_pvlan.TestPVLAN) ... === TestName: test_create_pvlan_network | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 6.542s
OK
Thanks,
Santhosh Edukulla