You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/12/01 08:46:06 UTC
[GitHub] [incubator-kvrocks] CNLHC opened a new pull request, #1149: refactor: move VERSION to src/folder #1148
CNLHC opened a new pull request, #1149:
URL: https://github.com/apache/incubator-kvrocks/pull/1149
solve #1148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] CNLHC commented on pull request #1149: refactor: move VERSION to src/folder #1148
Posted by GitBox <gi...@apache.org>.
CNLHC commented on PR #1149:
URL: https://github.com/apache/incubator-kvrocks/pull/1149#issuecomment-1333805460
> I'd prefer to write `VERSION.txt` instead of `.VERSION`. There's no reason for the VERSION file to be hidden.
>
> @PragmaTwice for [#1148 (comment)](https://github.com/apache/incubator-kvrocks/issues/1148#issuecomment-1333696239), I'd say that `version.h.in` is not a typical source file also, but we host all source files and meta source files (that generates source files under `src`). You can think of proto definitions.
I agree with @tisonkun that the `VERSION` should be placed in the `src` because this file does influence the output binary and can be regarded as some kind of source file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1149: refactor: move VERSION to src/folder #1148
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #1149:
URL: https://github.com/apache/incubator-kvrocks/pull/1149#issuecomment-1334010442
> @PragmaTwice Another approach is that we thoroughly remove the `VERSION` file but pass the version by CMake option and default to `999.999.999` :)
It seems it is hard to do so in a source distribution, while users are required to specify a version number to build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #1149: refactor: move VERSION to src/folder #1148
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #1149:
URL: https://github.com/apache/incubator-kvrocks/pull/1149#issuecomment-1334737390
Thanks for your contribution! Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #1149: refactor: move VERSION to src/folder #1148
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #1149:
URL: https://github.com/apache/incubator-kvrocks/pull/1149#issuecomment-1334014911
> It seems hard to do so in a source distribution, while users are required to specify a version number to build.
Yep..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] CNLHC commented on pull request #1149: refactor: move VERSION to src/folder #1148
Posted by GitBox <gi...@apache.org>.
CNLHC commented on PR #1149:
URL: https://github.com/apache/incubator-kvrocks/pull/1149#issuecomment-1333427461
`x.py` is only invoked from the project root so using relative dir in `x.py` seems to be ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #1149: refactor: move VERSION to src/folder #1148
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #1149:
URL: https://github.com/apache/incubator-kvrocks/pull/1149#issuecomment-1333792008
I'd prefer to write `VERSION.txt` instead of `.VERSION`. There's no reason for the VERSION file to be hidden.
@PragmaTwice for https://github.com/apache/incubator-kvrocks/issues/1148#issuecomment-1333696239, I'd say that `version.h.in` is not a typical source file also, but we host all source files and meta source files (that generates source files under `src`). You can think of proto definitions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun merged pull request #1149: refactor: move VERSION to src/folder #1148
Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #1149:
URL: https://github.com/apache/incubator-kvrocks/pull/1149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org