You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/09/08 15:36:59 UTC

[GitHub] [brooklyn-server] ahgittin opened a new pull request #1253: be smarter about picking which component is referenced by DSL

ahgittin opened a new pull request #1253:
URL: https://github.com/apache/brooklyn-server/pull/1253


   prefer those:
   - crossing fewer application boundaries
   - closer


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [brooklyn-server] iuliana commented on a change in pull request #1253: be smarter about picking which component is referenced by DSL

Posted by GitBox <gi...@apache.org>.
iuliana commented on a change in pull request #1253:
URL: https://github.com/apache/brooklyn-server/pull/1253#discussion_r704552570



##########
File path: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/DslYamlTest.java
##########
@@ -689,7 +689,7 @@ public void testDeferredDslChainingOnSensor() throws Exception {
         assertEquals(getConfigEventually(app, DEST), Boolean.TRUE);
     }
 
-    @Test
+    @Test(groups="Integration")  // because takes 3 seconds ... not sure why!?

Review comment:
       This ran in normal time for me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [brooklyn-server] iuliana merged pull request #1253: be smarter about picking which component is referenced by DSL

Posted by GitBox <gi...@apache.org>.
iuliana merged pull request #1253:
URL: https://github.com/apache/brooklyn-server/pull/1253


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org