You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/13 20:12:27 UTC
[GitHub] [beam] damccorm opened a new pull request, #21836: Update references to Jira to GH for the Java SDK
damccorm opened a new pull request, #21836:
URL: https://github.com/apache/beam/pull/21836
Part of https://github.com/apache/beam/issues/21812
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1157904228
Run Java_PVR_Flink_Docker PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1156852821
Run Spotless PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1157607868
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1156582640
Run Java_PVR_Flink_Docker PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit merged pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged PR #21836:
URL: https://github.com/apache/beam/pull/21836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1154383821
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1155680070
Run Java_PVR_Flink_Batch PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1155757595
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1155707765
Run Kotlin_Examples PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1154383823
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1156526556
Run Kotlin_Examples PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1156582247
Run Python_PVR_Flink PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1156508830
Run Python_PVR_Flink PreCommit
Run Kotlin_Examples PreCommit
Run Java_PVR_Flink_Docker PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a diff in pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on code in PR #21836:
URL: https://github.com/apache/beam/pull/21836#discussion_r899429106
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnInvokersTest.java:
##########
@@ -93,7 +93,8 @@
@SuppressWarnings({
"rawtypes", // TODO(https://github.com/apache/beam/issues/20447)
"SameNameButDifferent",
- "unused" // TODO(BEAM-13271): Remove when new version of errorprone is released (2.11.0)
+ "unused" // TODO(https://github.com/apache/beam/issues/21230): Remove when new version of
+ // errorprone is released (2.11.0)
Review Comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1156582485
Run Kotlin_Examples PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1154382921
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1156852644
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1154383830
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1156526420
Run Python_PVR_Flink PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1156852940
Run Java_PVR_Flink_Batch PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1157016586
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1156547790
Run Python_PVR_Flink PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a diff in pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on code in PR #21836:
URL: https://github.com/apache/beam/pull/21836#discussion_r897395438
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnInvokersTest.java:
##########
@@ -93,7 +93,8 @@
@SuppressWarnings({
"rawtypes", // TODO(https://github.com/apache/beam/issues/20447)
"SameNameButDifferent",
- "unused" // TODO(BEAM-13271): Remove when new version of errorprone is released (2.11.0)
+ "unused" // TODO(https://github.com/apache/beam/issues/21230): Remove when new version of
+ // errorprone is released (2.11.0)
Review Comment:
These look weird, any chance your automation could move these comments to the line above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1154383827
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1156526683
Run Java_PVR_Flink_Docker PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1156582814
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21836:
URL: https://github.com/apache/beam/pull/21836#issuecomment-1155707594
Run Java_Examples_Dataflow PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #21836: Update references to Jira to GH for the Java SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #21836:
URL: https://github.com/apache/beam/pull/21836#discussion_r897984978
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnInvokersTest.java:
##########
@@ -93,7 +93,8 @@
@SuppressWarnings({
"rawtypes", // TODO(https://github.com/apache/beam/issues/20447)
"SameNameButDifferent",
- "unused" // TODO(BEAM-13271): Remove when new version of errorprone is released (2.11.0)
+ "unused" // TODO(https://github.com/apache/beam/issues/21230): Remove when new version of
+ // errorprone is released (2.11.0)
Review Comment:
I think this was actually caused by the autoformatter (spotlessApply), not my automation itself. With that said, I manually went through and cleaned it up (and some other weird formatting things)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org