[GitHub] [helix] desaikomal commented on a diff in pull request #2357: Enable MSDS auto refresh for DedicatedZkClient

["desaikomal (via GitHub)" <gi...@apache.org>]

desaikomal commented on code in PR #2357:
URL: https://github.com/apache/helix/pull/2357#discussion_r1094631966


##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/routing/RoutingDataManager.java:
##########
@@ -166,8 +172,18 @@ public MetadataStoreRoutingData getMetadataStoreRoutingData(
 
   /**
    * Clears the statically-cached routing data and private fields.
+   * @param isForcedReset - if true, ignore throttle settings
    */
-  public synchronized void reset() {
+  public synchronized void reset(boolean isForcedReset) {

Review Comment:
   all the methods in this change are calling with "true". and pure reset() is private. so do we really have a usecase with "false" ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org