You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Vikas Saurabh (JIRA)" <ji...@apache.org> on 2015/08/26 12:44:45 UTC
[jira] [Comment Edited] (OAK-3230) Query engine should support
virtual index rows
[ https://issues.apache.org/jira/browse/OAK-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712926#comment-14712926 ]
Vikas Saurabh edited comment on OAK-3230 at 8/26/15 10:44 AM:
--------------------------------------------------------------
I'm not sure of the version change part. Would that mean that we should find some other (api wise backward compatible) change?
-About tests, the only place which emits virtual row is lucene suggest/spell check. I think there's isn't a legitimate query which would form aggregate cursor over suggest/spell check. But, yes, we can probably skip query dynamic and unit test the cursor implementations.-
Didn't see last comnent from Thomas
was (Author: catholicon):
I'm not sure of the version change part. Would that mean that we should find some other (api wise backward compatible) change?
About tests, the only place which emits virtual row is lucene suggest/spell check. I think there's isn't a legitimate query which would form aggregate cursor over suggest/spell check. But, yes, we can probably skip query dynamic and unit test the cursor implementations.
> Query engine should support virtual index rows
> ----------------------------------------------
>
> Key: OAK-3230
> URL: https://issues.apache.org/jira/browse/OAK-3230
> Project: Jackrabbit Oak
> Issue Type: Sub-task
> Components: query
> Reporter: Vikas Saurabh
> Assignee: Thomas Mueller
> Fix For: 1.3.5
>
> Attachments: OAK-3230-query-engine-should-support-virtual-rows.patch
>
>
> As discussed in OAK-3156 [here|https://issues.apache.org/jira/browse/OAK-3156?focusedCommentId=14645712&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14645712] and [here|https://issues.apache.org/jira/browse/OAK-3156?focusedCommentId=14655273&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14655273], we need support for virtual rows returned by indices (rows where path property doesn't make sense).
> Talked to [~tmueller] and we should have a new method in {{IndexRow}} to clearly mark the intent that the row is virtual and hence should be treated accordingly by the query engine.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)