You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Gregory Hart (Updated) (JIRA)" <ji...@apache.org> on 2012/03/29 01:39:29 UTC

[jira] [Updated] (THRIFT-1548) PHP TCompactProtocol always reads bools as false

     [ https://issues.apache.org/jira/browse/THRIFT-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Hart updated THRIFT-1548:
---------------------------------

    Attachment: TCompactProtocol.php.patch

The patch is attached.
                
> PHP TCompactProtocol always reads bools as false
> ------------------------------------------------
>
>                 Key: THRIFT-1548
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1548
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Library
>    Affects Versions: 0.8
>            Reporter: Gregory Hart
>         Attachments: TCompactProtocol.php.patch
>
>
> In TCompactProtocol::readFieldBegin, $field_type should be compared to COMPACT_TRUE or COMPACT_FALSE before being converted to a TType. Otherwise, $field_type will be converted to TType::BOOL (0x02) and will always match COMPACT_FALSE (0x02).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira