[GitHub] [incubator-nuttx] hartmannathan commented on a diff in pull request #7431: net: move IPv4/6BUF define to common header

[GitBox <gi...@apache.org>]

hartmannathan commented on code in PR #7431:
URL: https://github.com/apache/incubator-nuttx/pull/7431#discussion_r1006823472


##########
arch/arm/src/tiva/lm/lm3s_ethernet.c:
##########
@@ -675,10 +671,11 @@ static int tiva_txpoll(struct net_driver_s *dev)
 
 static void tiva_receive(struct tiva_driver_s *priv)
 {
+  struct net_driver_s *dev = &priv->ld_dev;

Review Comment:
   Ditto: Did you intend to replace all `priv->ld_dev.` below with `dev->`?



##########
drivers/net/tun.c:
##########
@@ -619,6 +614,8 @@ static void tun_net_receive_tap(FAR struct tun_device_s *priv)
 
 static void tun_net_receive_tun(FAR struct tun_device_s *priv)
 {
+  FAR struct net_driver_s *dev = &priv->dev;

Review Comment:
   Ditto



##########
arch/arm/src/lpc54xx/lpc54_ethernet.c:
##########
@@ -934,6 +933,8 @@ static void lpc54_eth_reply(struct lpc54_ethdriver_s *priv)
 
 static void lpc54_eth_rxdispatch(struct lpc54_ethdriver_s *priv)
 {
+  struct net_driver_s *dev = &priv->eth_dev;

Review Comment:
   This variable (`dev`) is not used in this function. Perhaps you intended to change all `&priv->eth_dev` below?



##########
drivers/net/slip.c:
##########
@@ -618,6 +614,7 @@ static int slip_rxtask(int argc, FAR char *argv[])
 
   /* Loop forever */
 
+  dev = &priv->dev;

Review Comment:
   Ditto: replace all `priv->dev.` with `dev->` below...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org