You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/23 08:38:13 UTC

[GitHub] [flink-table-store] zjureel commented on pull request #399: [FLINK-30161] Add table schema validation for full compaction

zjureel commented on PR #399:
URL: https://github.com/apache/flink-table-store/pull/399#issuecomment-1324709079

   > Thanks @zjureel !
   > 
   > I find that all kinds of verifications are a bit messy. Can we propose a verification method (Maybe a static method in `CoreOptions`)? It can be called in two places:
   > 
   > 1. `SchemaManager.commit`: When submitting new schema changes.
   > 2. `FileStoreTableFactory.create`: When creating a new table, the verification here is because there may be dynamic options, which also need to be verified.
   
   Sounds good to me, I found there are validations in `CoreOptions` too, we should merge them


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org