You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/11/10 07:26:21 UTC
[GitHub] [rocketmq] ShadowySpirits opened a new pull request, #5503: invert dependency between remoting and common module
ShadowySpirits opened a new pull request, #5503:
URL: https://github.com/apache/rocketmq/pull/5503
close #5502
## Detailed changes
- move org.apache.rocketmq.common.protocol to org.apache.rocketmq.remoting.protocol
- move all classes that extend RemotingSerializable to org.apache.rocketmq.remoting.protocol
- move org.apache.rocketmq.remoting.common.RemotingUtil to org.apache.rocketmq.common.utils.NetworkUtil
- move org.apache.rocketmq.remoting.common.RemotingHelper#exceptionSimpleDesc to org.apache.rocketmq.common.UtilAll#exceptionSimpleDesc
- remove some functions in TopicValidator: no longer handle response in TopicValidator
- fix tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ShadowySpirits commented on pull request #5503: invert dependency between remoting and common module
Posted by GitBox <gi...@apache.org>.
ShadowySpirits commented on PR #5503:
URL: https://github.com/apache/rocketmq/pull/5503#issuecomment-1310298486
> The class `ServiceThread` is repeated.
we can not remove org.apache.rocketmq.remoting.common.ServiceThread for now because dledger depends on it. I removed all uses of it in RocketMQ, and this duplicate class will be removed in the next pr after fixing dledger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui commented on pull request #5503: invert dependency between remoting and common module
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #5503:
URL: https://github.com/apache/rocketmq/pull/5503#issuecomment-1311154563
> > The class `ServiceThread` is repeated.
>
> We can not remove org.apache.rocketmq.remoting.common.ServiceThread for now because dledger depends on it. I removed all uses of it in RocketMQ, and this duplicate class will be removed in the next pr after fixing dledger.
OK, it makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui merged pull request #5503: invert dependency between remoting and common module
Posted by GitBox <gi...@apache.org>.
lizhanhui merged PR #5503:
URL: https://github.com/apache/rocketmq/pull/5503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] drpmma commented on pull request #5503: invert dependency between remoting and common module
Posted by GitBox <gi...@apache.org>.
drpmma commented on PR #5503:
URL: https://github.com/apache/rocketmq/pull/5503#issuecomment-1310163167
The class `ServiceThread` is repeated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org