You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/11/15 08:44:54 UTC
[GitHub] [servicecomb-java-chassis] GuoYL123 commented on a change in pull
request #1376: [SCB-1588]ServerListFilterExt add switch
GuoYL123 commented on a change in pull request #1376: [SCB-1588]ServerListFilterExt add switch
URL: https://github.com/apache/servicecomb-java-chassis/pull/1376#discussion_r346713144
##########
File path: handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadBalancer.java
##########
@@ -58,7 +58,9 @@ public ServiceCombServer chooseServer(Invocation invocation) {
List<ServiceCombServer> servers = invocation.getLocalContext(LoadbalanceHandler.CONTEXT_KEY_SERVER_LIST);
int serversCount = servers.size();
for (ServerListFilterExt filterExt : filters) {
- servers = filterExt.getFilteredListOfServers(servers, invocation);
+ if(filterExt.enabled()) {
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services