You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/14 04:58:09 UTC
[GitHub] [skywalking] klboke opened a new issue #6749: About the value of service_instance_id in receiver_zipkin
klboke opened a new issue #6749:
URL: https://github.com/apache/skywalking/issues/6749
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ 1] Bug
- [ ] Requirement
- [ ] Feature or performance improvement
___
### Bug
- Which version of SkyWalking, OS, and JRE?
1. OS : mac os 10.15.7
2. JRE : jdk1.8
3. skywalking version ：8.5.0
4. elasticsearch version ：7.10.2
- Which company or project?
TapTap
- What happened?
I tried to use receiver_zipkin in spring cloud and istio environment. But there are bugs. When ui query trace, this exception will appear: `Cannot return null for non-nullable type:'ID' within parent'Span' (/trace/spans[0]/serviceInstanceName`. For example:
I have located the reason, which is caused by the lack of ServiceInstanceId in the span entity that was queried. I went to look at the processing logic of zipkin when receiving data, and found that there is no processing logic for ServiceInstanceId
___
### Requirement or improvement
- Please describe your requirements or improvement suggestions.
I learned that there is no definition of ServiceInstanceId in the zipkin data model, and then found that there is spring.InstanceId in the zipkin tags in the spring-cloud environment. There is node.id in the tags of istio's zipkin. These are very suitable to be used as ServiceInstanceId.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6749: About the value of service_instance_id in receiver_zipkin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6749:
URL: https://github.com/apache/skywalking/issues/6749#issuecomment-819246977
We could adpot Spring if you like, and set an empty as name in default. Welcome to send a pull request to fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] klboke commented on issue #6749: About the value of service_instance_id in receiver_zipkin
Posted by GitBox <gi...@apache.org>.
klboke commented on issue #6749:
URL: https://github.com/apache/skywalking/issues/6749#issuecomment-819272607
Okay, design to get the naming corresponding to service_instance_id in tags from receiver_zipkin. I will follow up on this issue and submit pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] klboke commented on issue #6749: About the value of service_instance_id in receiver_zipkin
Posted by GitBox <gi...@apache.org>.
klboke commented on issue #6749:
URL: https://github.com/apache/skywalking/issues/6749#issuecomment-819252875
No problem, I plan to first be compatible with the naming of zipkin tags in the istio and spring environments. Then if there is not, set a default empty, you see if this is ok. If there is no problem, I will start to develop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #6749: About the value of service_instance_id in receiver_zipkin
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #6749:
URL: https://github.com/apache/skywalking/issues/6749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6749: About the value of service_instance_id in receiver_zipkin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6749:
URL: https://github.com/apache/skywalking/issues/6749#issuecomment-819256222
Generally, you could set a list of tag keys and try to set an instance name. If nothing found, set a default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org