You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2010/05/11 21:11:41 UTC

[jira] Created: (CASSANDRA-1077) clean up ExpiringMap

clean up ExpiringMap
--------------------

                 Key: CASSANDRA-1077
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1077
             Project: Cassandra
          Issue Type: Improvement
          Components: Core
            Reporter: Jonathan Ellis
            Assignee: Jonathan Ellis
            Priority: Minor
             Fix For: 0.7




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1077) clean up ExpiringMap

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866381#action_12866381 ] 

Gary Dusbabek commented on CASSANDRA-1077:
------------------------------------------

I don't think there is a convention.  It's just that V seemed appropriate to me since that's what will end up there.  Better reading code?

> clean up ExpiringMap
> --------------------
>
>                 Key: CASSANDRA-1077
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1077
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-inline-ReadRepairManager-and-r-m-unused-code.txt, 0002-replace-ExpiringMap-in-ConsistencyChecker-with-Schedul.txt, 0003-clean-up-ExpiringMap-and-improve-concurrency-w-NBHM-in.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1077) clean up ExpiringMap

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866364#action_12866364 ] 

Jonathan Ellis commented on CASSANDRA-1077:
-------------------------------------------

i want to avoid confusion with the V in K,V of the parent class, since they are distinct types

what is the convention there?

> clean up ExpiringMap
> --------------------
>
>                 Key: CASSANDRA-1077
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1077
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-inline-ReadRepairManager-and-r-m-unused-code.txt, 0002-replace-ExpiringMap-in-ConsistencyChecker-with-Schedul.txt, 0003-clean-up-ExpiringMap-and-improve-concurrency-w-NBHM-in.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1077) clean up ExpiringMap

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866352#action_12866352 ] 

Gary Dusbabek commented on CASSANDRA-1077:
------------------------------------------

+1.

Any reason for using <W> for the CacheableObject generic instead of <V> in ExpiringMap?

> clean up ExpiringMap
> --------------------
>
>                 Key: CASSANDRA-1077
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1077
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-inline-ReadRepairManager-and-r-m-unused-code.txt, 0002-replace-ExpiringMap-in-ConsistencyChecker-with-Schedul.txt, 0003-clean-up-ExpiringMap-and-improve-concurrency-w-NBHM-in.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1077) clean up ExpiringMap

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-1077:
--------------------------------------

    Attachment: 0001-inline-ReadRepairManager-and-r-m-unused-code.txt
                0002-replace-ExpiringMap-in-ConsistencyChecker-with-Schedul.txt
                0003-clean-up-ExpiringMap-and-improve-concurrency-w-NBHM-in.txt

> clean up ExpiringMap
> --------------------
>
>                 Key: CASSANDRA-1077
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1077
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-inline-ReadRepairManager-and-r-m-unused-code.txt, 0002-replace-ExpiringMap-in-ConsistencyChecker-with-Schedul.txt, 0003-clean-up-ExpiringMap-and-improve-concurrency-w-NBHM-in.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1077) clean up ExpiringMap

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866285#action_12866285 ] 

Jonathan Ellis commented on CASSANDRA-1077:
-------------------------------------------

03
    clean up ExpiringMap and improve concurrency w/ NBHM instead of HashTable

02
    replace ExpiringMap in ConsistencyChecker with ScheduledExecutorService

01
    inline ReadRepairManager and r/m unused code


> clean up ExpiringMap
> --------------------
>
>                 Key: CASSANDRA-1077
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1077
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-inline-ReadRepairManager-and-r-m-unused-code.txt, 0002-replace-ExpiringMap-in-ConsistencyChecker-with-Schedul.txt, 0003-clean-up-ExpiringMap-and-improve-concurrency-w-NBHM-in.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1077) clean up ExpiringMap

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866365#action_12866365 ] 

Jonathan Ellis commented on CASSANDRA-1077:
-------------------------------------------

... i guess i should probably just use T, huh.

still, i'm curious what you would do if you already had a T...

> clean up ExpiringMap
> --------------------
>
>                 Key: CASSANDRA-1077
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1077
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-inline-ReadRepairManager-and-r-m-unused-code.txt, 0002-replace-ExpiringMap-in-ConsistencyChecker-with-Schedul.txt, 0003-clean-up-ExpiringMap-and-improve-concurrency-w-NBHM-in.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.