You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by dk...@apache.org on 2014/08/15 20:24:17 UTC
[1/2] git commit: Remove a bunch of unused imports and other
unnecessary warnings
Repository: camel
Updated Branches:
refs/heads/master 518734fd6 -> d292dbf20
Remove a bunch of unused imports and other unnecessary warnings
Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/f8f45700
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/f8f45700
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/f8f45700
Branch: refs/heads/master
Commit: f8f457009b0ff82bf1a990799d6f51c3c7f2002c
Parents: 518734f
Author: Daniel Kulp <dk...@apache.org>
Authored: Fri Aug 15 13:45:26 2014 -0400
Committer: Daniel Kulp <dk...@apache.org>
Committed: Fri Aug 15 13:45:26 2014 -0400
----------------------------------------------------------------------
.../camel/management/mbean/ManagedBacklogDebugger.java | 1 -
.../org/apache/camel/util/component/AbstractApiConsumer.java | 4 ----
.../org/apache/camel/util/component/AbstractApiEndpoint.java | 2 --
.../org/apache/camel/util/component/AbstractApiProducer.java | 3 ---
.../ManagedProducerRecipientListRegisterAlwaysTest.java | 1 -
.../camel/management/ManagedProducerRecipientListTest.java | 2 --
.../ManagedProducerRouteAddRemoveRegisterAlwaysTest.java | 2 --
.../camel/core/xml/AbstractCamelContextFactoryBean.java | 8 +++++---
.../jackson/SpringJacksonMarshalUnmarshalListTest.java | 2 --
.../camel/component/netty/http/ContextPathMatcher.java | 2 --
.../netty/http/rest/RestNettyHttpPojoInOutTest.java | 2 --
.../netty/http/rest/RestNettyHttpPostJsonJaxbPojoTest.java | 2 --
.../netty/http/rest/RestNettyHttpPostJsonPojoTest.java | 2 --
.../component/netty/UnsharableCodecsConflicts2Test.java | 1 -
.../camel/component/netty/UnsharableCodecsConflictsTest.java | 1 -
.../org/apache/camel/component/quartz/QuartzComponent.java | 1 -
.../servlet/ServletRestServletResolveConsumerStrategy.java | 3 ---
.../ServletComponentConfigurationAndDocumentationTest.java | 1 -
.../camel/component/sparkrest/RestCamelSparkParamTest.java | 1 -
.../org/apache/camel/component/velocity/VelocityTest.java | 1 -
20 files changed, 5 insertions(+), 37 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/camel/blob/f8f45700/camel-core/src/main/java/org/apache/camel/management/mbean/ManagedBacklogDebugger.java
----------------------------------------------------------------------
diff --git a/camel-core/src/main/java/org/apache/camel/management/mbean/ManagedBacklogDebugger.java b/camel-core/src/main/java/org/apache/camel/management/mbean/ManagedBacklogDebugger.java
index 9693120..9baf5fb 100644
--- a/camel-core/src/main/java/org/apache/camel/management/mbean/ManagedBacklogDebugger.java
+++ b/camel-core/src/main/java/org/apache/camel/management/mbean/ManagedBacklogDebugger.java
@@ -20,7 +20,6 @@ import java.util.Set;
import org.apache.camel.CamelContext;
import org.apache.camel.NoTypeConversionAvailableException;
-import org.apache.camel.Predicate;
import org.apache.camel.api.management.ManagedResource;
import org.apache.camel.api.management.mbean.ManagedBacklogDebuggerMBean;
import org.apache.camel.processor.interceptor.BacklogDebugger;
http://git-wip-us.apache.org/repos/asf/camel/blob/f8f45700/camel-core/src/main/java/org/apache/camel/util/component/AbstractApiConsumer.java
----------------------------------------------------------------------
diff --git a/camel-core/src/main/java/org/apache/camel/util/component/AbstractApiConsumer.java b/camel-core/src/main/java/org/apache/camel/util/component/AbstractApiConsumer.java
index b0f50e8..dc14855 100644
--- a/camel-core/src/main/java/org/apache/camel/util/component/AbstractApiConsumer.java
+++ b/camel-core/src/main/java/org/apache/camel/util/component/AbstractApiConsumer.java
@@ -80,13 +80,11 @@ public abstract class AbstractApiConsumer<E extends Enum<E> & ApiName, T>
}
@Override
- @SuppressWarnings("unused")
public void interceptPropertyNames(Set<String> propertyNames) {
// do nothing by default
}
@Override
- @SuppressWarnings("unused")
public void interceptProperties(Map<String, Object> properties) {
// do nothing by default
}
@@ -114,7 +112,6 @@ public abstract class AbstractApiConsumer<E extends Enum<E> & ApiName, T>
}
@Override
- @SuppressWarnings("unused")
public void interceptResult(Object result, Exchange resultExchange) {
// do nothing by default
}
@@ -133,7 +130,6 @@ public abstract class AbstractApiConsumer<E extends Enum<E> & ApiName, T>
return splitResult;
}
- @SuppressWarnings("unused")
public final void setSplitResult(boolean splitResult) {
this.splitResult = splitResult;
}
http://git-wip-us.apache.org/repos/asf/camel/blob/f8f45700/camel-core/src/main/java/org/apache/camel/util/component/AbstractApiEndpoint.java
----------------------------------------------------------------------
diff --git a/camel-core/src/main/java/org/apache/camel/util/component/AbstractApiEndpoint.java b/camel-core/src/main/java/org/apache/camel/util/component/AbstractApiEndpoint.java
index 68a9df6..a36cd70 100644
--- a/camel-core/src/main/java/org/apache/camel/util/component/AbstractApiEndpoint.java
+++ b/camel-core/src/main/java/org/apache/camel/util/component/AbstractApiEndpoint.java
@@ -167,13 +167,11 @@ public abstract class AbstractApiEndpoint<E extends ApiName, T>
}
@Override
- @SuppressWarnings("unused")
public void interceptPropertyNames(Set<String> propertyNames) {
// do nothing by default
}
@Override
- @SuppressWarnings("unused")
public void interceptProperties(Map<String, Object> properties) {
// do nothing by default
}
http://git-wip-us.apache.org/repos/asf/camel/blob/f8f45700/camel-core/src/main/java/org/apache/camel/util/component/AbstractApiProducer.java
----------------------------------------------------------------------
diff --git a/camel-core/src/main/java/org/apache/camel/util/component/AbstractApiProducer.java b/camel-core/src/main/java/org/apache/camel/util/component/AbstractApiProducer.java
index 9995615..11b7c74 100644
--- a/camel-core/src/main/java/org/apache/camel/util/component/AbstractApiProducer.java
+++ b/camel-core/src/main/java/org/apache/camel/util/component/AbstractApiProducer.java
@@ -20,7 +20,6 @@ import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Set;
-import java.util.concurrent.ExecutorService;
import org.apache.camel.AsyncCallback;
import org.apache.camel.Exchange;
@@ -106,7 +105,6 @@ public abstract class AbstractApiProducer<E extends Enum<E> & ApiName, T>
}
@Override
- @SuppressWarnings("unused")
public void interceptProperties(Map<String, Object> properties) {
// do nothing by default
}
@@ -129,7 +127,6 @@ public abstract class AbstractApiProducer<E extends Enum<E> & ApiName, T>
}
@Override
- @SuppressWarnings("unused")
public void interceptResult(Object methodResult, Exchange resultExchange) {
// do nothing by default
}
http://git-wip-us.apache.org/repos/asf/camel/blob/f8f45700/camel-core/src/test/java/org/apache/camel/management/ManagedProducerRecipientListRegisterAlwaysTest.java
----------------------------------------------------------------------
diff --git a/camel-core/src/test/java/org/apache/camel/management/ManagedProducerRecipientListRegisterAlwaysTest.java b/camel-core/src/test/java/org/apache/camel/management/ManagedProducerRecipientListRegisterAlwaysTest.java
index 99aff3e..96d72fb 100644
--- a/camel-core/src/test/java/org/apache/camel/management/ManagedProducerRecipientListRegisterAlwaysTest.java
+++ b/camel-core/src/test/java/org/apache/camel/management/ManagedProducerRecipientListRegisterAlwaysTest.java
@@ -24,7 +24,6 @@ import javax.management.ObjectName;
import org.apache.camel.CamelContext;
import org.apache.camel.ServiceStatus;
import org.apache.camel.builder.RouteBuilder;
-import org.apache.camel.component.mock.MockEndpoint;
/**
* @version
http://git-wip-us.apache.org/repos/asf/camel/blob/f8f45700/camel-core/src/test/java/org/apache/camel/management/ManagedProducerRecipientListTest.java
----------------------------------------------------------------------
diff --git a/camel-core/src/test/java/org/apache/camel/management/ManagedProducerRecipientListTest.java b/camel-core/src/test/java/org/apache/camel/management/ManagedProducerRecipientListTest.java
index 45f1f5a..0277ee0 100644
--- a/camel-core/src/test/java/org/apache/camel/management/ManagedProducerRecipientListTest.java
+++ b/camel-core/src/test/java/org/apache/camel/management/ManagedProducerRecipientListTest.java
@@ -16,12 +16,10 @@
*/
package org.apache.camel.management;
-import java.util.Iterator;
import java.util.Set;
import javax.management.MBeanServer;
import javax.management.ObjectName;
-import org.apache.camel.ServiceStatus;
import org.apache.camel.builder.RouteBuilder;
/**
http://git-wip-us.apache.org/repos/asf/camel/blob/f8f45700/camel-core/src/test/java/org/apache/camel/management/ManagedProducerRouteAddRemoveRegisterAlwaysTest.java
----------------------------------------------------------------------
diff --git a/camel-core/src/test/java/org/apache/camel/management/ManagedProducerRouteAddRemoveRegisterAlwaysTest.java b/camel-core/src/test/java/org/apache/camel/management/ManagedProducerRouteAddRemoveRegisterAlwaysTest.java
index 60432b1..a8201e3 100644
--- a/camel-core/src/test/java/org/apache/camel/management/ManagedProducerRouteAddRemoveRegisterAlwaysTest.java
+++ b/camel-core/src/test/java/org/apache/camel/management/ManagedProducerRouteAddRemoveRegisterAlwaysTest.java
@@ -16,13 +16,11 @@
*/
package org.apache.camel.management;
-import java.util.Iterator;
import java.util.Set;
import javax.management.MBeanServer;
import javax.management.ObjectName;
import org.apache.camel.CamelContext;
-import org.apache.camel.ServiceStatus;
import org.apache.camel.builder.RouteBuilder;
import org.apache.camel.component.mock.MockEndpoint;
http://git-wip-us.apache.org/repos/asf/camel/blob/f8f45700/components/camel-core-xml/src/main/java/org/apache/camel/core/xml/AbstractCamelContextFactoryBean.java
----------------------------------------------------------------------
diff --git a/components/camel-core-xml/src/main/java/org/apache/camel/core/xml/AbstractCamelContextFactoryBean.java b/components/camel-core-xml/src/main/java/org/apache/camel/core/xml/AbstractCamelContextFactoryBean.java
index 51afc9c..1b0fdd1 100644
--- a/components/camel-core-xml/src/main/java/org/apache/camel/core/xml/AbstractCamelContextFactoryBean.java
+++ b/components/camel-core-xml/src/main/java/org/apache/camel/core/xml/AbstractCamelContextFactoryBean.java
@@ -24,6 +24,7 @@ import java.util.Map;
import java.util.Map.Entry;
import java.util.Set;
import java.util.concurrent.atomic.AtomicBoolean;
+
import javax.xml.bind.annotation.XmlAccessType;
import javax.xml.bind.annotation.XmlAccessorType;
import javax.xml.bind.annotation.XmlTransient;
@@ -65,7 +66,6 @@ import org.apache.camel.model.rest.RestConfigurationDefinition;
import org.apache.camel.model.rest.RestContainer;
import org.apache.camel.model.rest.RestDefinition;
import org.apache.camel.processor.interceptor.BacklogTracer;
-import org.apache.camel.processor.interceptor.Delayer;
import org.apache.camel.processor.interceptor.HandleFault;
import org.apache.camel.processor.interceptor.TraceFormatter;
import org.apache.camel.processor.interceptor.Tracer;
@@ -192,7 +192,9 @@ public abstract class AbstractCamelContextFactoryBean<T extends ModelCamelContex
LOG.info("Using custom HandleFault: {}", handleFault);
getContext().addInterceptStrategy(handleFault);
}
- Delayer delayer = getBeanForType(Delayer.class);
+ @SuppressWarnings("deprecation")
+ org.apache.camel.processor.interceptor.Delayer delayer
+ = getBeanForType(org.apache.camel.processor.interceptor.Delayer.class);
if (delayer != null) {
LOG.info("Using custom Delayer: {}", delayer);
getContext().addInterceptStrategy(delayer);
@@ -468,7 +470,7 @@ public abstract class AbstractCamelContextFactoryBean<T extends ModelCamelContex
}
String spoolRules = CamelContextHelper.parseText(getContext(), streamCaching.getAnySpoolRules());
if (spoolRules != null) {
- Iterator it = ObjectHelper.createIterator(spoolRules);
+ Iterator<Object> it = ObjectHelper.createIterator(spoolRules);
while (it.hasNext()) {
String name = it.next().toString();
StreamCachingStrategy.SpoolRule rule = getContext().getRegistry().lookupByNameAndType(name, StreamCachingStrategy.SpoolRule.class);
http://git-wip-us.apache.org/repos/asf/camel/blob/f8f45700/components/camel-jackson/src/test/java/org/apache/camel/component/jackson/SpringJacksonMarshalUnmarshalListTest.java
----------------------------------------------------------------------
diff --git a/components/camel-jackson/src/test/java/org/apache/camel/component/jackson/SpringJacksonMarshalUnmarshalListTest.java b/components/camel-jackson/src/test/java/org/apache/camel/component/jackson/SpringJacksonMarshalUnmarshalListTest.java
index 9a68b1d..019bf8c 100644
--- a/components/camel-jackson/src/test/java/org/apache/camel/component/jackson/SpringJacksonMarshalUnmarshalListTest.java
+++ b/components/camel-jackson/src/test/java/org/apache/camel/component/jackson/SpringJacksonMarshalUnmarshalListTest.java
@@ -16,9 +16,7 @@
*/
package org.apache.camel.component.jackson;
-import java.util.HashMap;
import java.util.List;
-import java.util.Map;
import org.apache.camel.component.mock.MockEndpoint;
import org.apache.camel.test.spring.CamelSpringTestSupport;
http://git-wip-us.apache.org/repos/asf/camel/blob/f8f45700/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/ContextPathMatcher.java
----------------------------------------------------------------------
diff --git a/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/ContextPathMatcher.java b/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/ContextPathMatcher.java
index df8498a..d607666 100644
--- a/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/ContextPathMatcher.java
+++ b/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/ContextPathMatcher.java
@@ -16,8 +16,6 @@
*/
package org.apache.camel.component.netty.http;
-import java.util.Locale;
-
/**
* A matcher used for selecting the correct {@link org.apache.camel.component.netty.http.handlers.HttpServerChannelHandler}
* to handle an incoming {@link org.jboss.netty.handler.codec.http.HttpRequest} when you use multiple routes on the same
http://git-wip-us.apache.org/repos/asf/camel/blob/f8f45700/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/rest/RestNettyHttpPojoInOutTest.java
----------------------------------------------------------------------
diff --git a/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/rest/RestNettyHttpPojoInOutTest.java b/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/rest/RestNettyHttpPojoInOutTest.java
index 06f4c28..4709fef 100644
--- a/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/rest/RestNettyHttpPojoInOutTest.java
+++ b/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/rest/RestNettyHttpPojoInOutTest.java
@@ -16,8 +16,6 @@
*/
package org.apache.camel.component.netty.http.rest;
-import org.apache.camel.Exchange;
-import org.apache.camel.Processor;
import org.apache.camel.builder.RouteBuilder;
import org.apache.camel.component.netty.http.BaseNettyTest;
import org.apache.camel.model.rest.RestBindingMode;
http://git-wip-us.apache.org/repos/asf/camel/blob/f8f45700/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/rest/RestNettyHttpPostJsonJaxbPojoTest.java
----------------------------------------------------------------------
diff --git a/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/rest/RestNettyHttpPostJsonJaxbPojoTest.java b/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/rest/RestNettyHttpPostJsonJaxbPojoTest.java
index 7f7b53b..b63bc8b 100644
--- a/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/rest/RestNettyHttpPostJsonJaxbPojoTest.java
+++ b/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/rest/RestNettyHttpPostJsonJaxbPojoTest.java
@@ -16,8 +16,6 @@
*/
package org.apache.camel.component.netty.http.rest;
-import org.apache.camel.Exchange;
-import org.apache.camel.Processor;
import org.apache.camel.builder.RouteBuilder;
import org.apache.camel.component.mock.MockEndpoint;
import org.apache.camel.component.netty.http.BaseNettyTest;
http://git-wip-us.apache.org/repos/asf/camel/blob/f8f45700/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/rest/RestNettyHttpPostJsonPojoTest.java
----------------------------------------------------------------------
diff --git a/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/rest/RestNettyHttpPostJsonPojoTest.java b/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/rest/RestNettyHttpPostJsonPojoTest.java
index 89774a0..4a39e60 100644
--- a/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/rest/RestNettyHttpPostJsonPojoTest.java
+++ b/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/rest/RestNettyHttpPostJsonPojoTest.java
@@ -16,8 +16,6 @@
*/
package org.apache.camel.component.netty.http.rest;
-import java.util.List;
-
import org.apache.camel.builder.RouteBuilder;
import org.apache.camel.component.mock.MockEndpoint;
import org.apache.camel.component.netty.http.BaseNettyTest;
http://git-wip-us.apache.org/repos/asf/camel/blob/f8f45700/components/camel-netty/src/test/java/org/apache/camel/component/netty/UnsharableCodecsConflicts2Test.java
----------------------------------------------------------------------
diff --git a/components/camel-netty/src/test/java/org/apache/camel/component/netty/UnsharableCodecsConflicts2Test.java b/components/camel-netty/src/test/java/org/apache/camel/component/netty/UnsharableCodecsConflicts2Test.java
index a90ba6a..9478a41 100644
--- a/components/camel-netty/src/test/java/org/apache/camel/component/netty/UnsharableCodecsConflicts2Test.java
+++ b/components/camel-netty/src/test/java/org/apache/camel/component/netty/UnsharableCodecsConflicts2Test.java
@@ -27,7 +27,6 @@ import org.apache.camel.Processor;
import org.apache.camel.builder.RouteBuilder;
import org.apache.camel.component.mock.MockEndpoint;
import org.apache.camel.impl.JndiRegistry;
-import org.jboss.netty.buffer.BigEndianHeapChannelBuffer;
import org.junit.Test;
/**
http://git-wip-us.apache.org/repos/asf/camel/blob/f8f45700/components/camel-netty/src/test/java/org/apache/camel/component/netty/UnsharableCodecsConflictsTest.java
----------------------------------------------------------------------
diff --git a/components/camel-netty/src/test/java/org/apache/camel/component/netty/UnsharableCodecsConflictsTest.java b/components/camel-netty/src/test/java/org/apache/camel/component/netty/UnsharableCodecsConflictsTest.java
index 129752e..6ebdb12 100644
--- a/components/camel-netty/src/test/java/org/apache/camel/component/netty/UnsharableCodecsConflictsTest.java
+++ b/components/camel-netty/src/test/java/org/apache/camel/component/netty/UnsharableCodecsConflictsTest.java
@@ -27,7 +27,6 @@ import org.apache.camel.builder.RouteBuilder;
import org.apache.camel.component.mock.MockEndpoint;
import org.apache.camel.impl.JndiRegistry;
import org.apache.camel.util.IOHelper;
-import org.jboss.netty.buffer.BigEndianHeapChannelBuffer;
import org.junit.Test;
/**
http://git-wip-us.apache.org/repos/asf/camel/blob/f8f45700/components/camel-quartz/src/main/java/org/apache/camel/component/quartz/QuartzComponent.java
----------------------------------------------------------------------
diff --git a/components/camel-quartz/src/main/java/org/apache/camel/component/quartz/QuartzComponent.java b/components/camel-quartz/src/main/java/org/apache/camel/component/quartz/QuartzComponent.java
index b3002f6..63f9dad 100644
--- a/components/camel-quartz/src/main/java/org/apache/camel/component/quartz/QuartzComponent.java
+++ b/components/camel-quartz/src/main/java/org/apache/camel/component/quartz/QuartzComponent.java
@@ -29,7 +29,6 @@ import java.util.concurrent.atomic.AtomicInteger;
import org.apache.camel.CamelContext;
import org.apache.camel.StartupListener;
-import org.apache.camel.impl.DefaultComponent;
import org.apache.camel.impl.UriEndpointComponent;
import org.apache.camel.util.EndpointHelper;
import org.apache.camel.util.IOHelper;
http://git-wip-us.apache.org/repos/asf/camel/blob/f8f45700/components/camel-servlet/src/main/java/org/apache/camel/component/servlet/ServletRestServletResolveConsumerStrategy.java
----------------------------------------------------------------------
diff --git a/components/camel-servlet/src/main/java/org/apache/camel/component/servlet/ServletRestServletResolveConsumerStrategy.java b/components/camel-servlet/src/main/java/org/apache/camel/component/servlet/ServletRestServletResolveConsumerStrategy.java
index c315fa5..1d5730e 100644
--- a/components/camel-servlet/src/main/java/org/apache/camel/component/servlet/ServletRestServletResolveConsumerStrategy.java
+++ b/components/camel-servlet/src/main/java/org/apache/camel/component/servlet/ServletRestServletResolveConsumerStrategy.java
@@ -17,15 +17,12 @@
package org.apache.camel.component.servlet;
import java.util.ArrayList;
-import java.util.Collections;
-import java.util.Comparator;
import java.util.Iterator;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import javax.servlet.http.HttpServletRequest;
-import org.apache.camel.component.bean.MethodInfo;
import org.apache.camel.component.http.HttpConsumer;
import org.apache.camel.component.http.HttpServletResolveConsumerStrategy;
http://git-wip-us.apache.org/repos/asf/camel/blob/f8f45700/components/camel-servlet/src/test/java/org/apache/camel/component/servlet/ServletComponentConfigurationAndDocumentationTest.java
----------------------------------------------------------------------
diff --git a/components/camel-servlet/src/test/java/org/apache/camel/component/servlet/ServletComponentConfigurationAndDocumentationTest.java b/components/camel-servlet/src/test/java/org/apache/camel/component/servlet/ServletComponentConfigurationAndDocumentationTest.java
index ebc2ab5..0098070 100644
--- a/components/camel-servlet/src/test/java/org/apache/camel/component/servlet/ServletComponentConfigurationAndDocumentationTest.java
+++ b/components/camel-servlet/src/test/java/org/apache/camel/component/servlet/ServletComponentConfigurationAndDocumentationTest.java
@@ -19,7 +19,6 @@ package org.apache.camel.component.servlet;
import org.apache.camel.CamelContext;
import org.apache.camel.ComponentConfiguration;
import org.apache.camel.EndpointConfiguration;
-import org.apache.camel.component.http.HttpComponent;
import org.apache.camel.impl.DefaultCamelContext;
import org.apache.camel.test.junit4.CamelTestSupport;
import org.junit.Test;
http://git-wip-us.apache.org/repos/asf/camel/blob/f8f45700/components/camel-spark-rest/src/test/java/org/apache/camel/component/sparkrest/RestCamelSparkParamTest.java
----------------------------------------------------------------------
diff --git a/components/camel-spark-rest/src/test/java/org/apache/camel/component/sparkrest/RestCamelSparkParamTest.java b/components/camel-spark-rest/src/test/java/org/apache/camel/component/sparkrest/RestCamelSparkParamTest.java
index 2ae55fe..bc0ab18 100644
--- a/components/camel-spark-rest/src/test/java/org/apache/camel/component/sparkrest/RestCamelSparkParamTest.java
+++ b/components/camel-spark-rest/src/test/java/org/apache/camel/component/sparkrest/RestCamelSparkParamTest.java
@@ -17,7 +17,6 @@
package org.apache.camel.component.sparkrest;
import org.apache.camel.builder.RouteBuilder;
-import org.junit.Test;
public class RestCamelSparkParamTest extends CamelSparkParamTest {
http://git-wip-us.apache.org/repos/asf/camel/blob/f8f45700/components/camel-velocity/src/test/java/org/apache/camel/component/velocity/VelocityTest.java
----------------------------------------------------------------------
diff --git a/components/camel-velocity/src/test/java/org/apache/camel/component/velocity/VelocityTest.java b/components/camel-velocity/src/test/java/org/apache/camel/component/velocity/VelocityTest.java
index fcecacf..e3b0cd1 100644
--- a/components/camel-velocity/src/test/java/org/apache/camel/component/velocity/VelocityTest.java
+++ b/components/camel-velocity/src/test/java/org/apache/camel/component/velocity/VelocityTest.java
@@ -25,7 +25,6 @@ import org.apache.camel.Exchange;
import org.apache.camel.Processor;
import org.apache.camel.builder.RouteBuilder;
import org.apache.camel.test.junit4.CamelTestSupport;
-import org.apache.camel.util.ExchangeHelper;
import org.apache.velocity.VelocityContext;
import org.junit.Test;
[2/2] git commit: Remove a bunch more eclipse warnings
Posted by dk...@apache.org.
Remove a bunch more eclipse warnings
Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/d292dbf2
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/d292dbf2
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/d292dbf2
Branch: refs/heads/master
Commit: d292dbf203998f417a20ba812451f687d951d9e7
Parents: f8f4570
Author: Daniel Kulp <dk...@apache.org>
Authored: Fri Aug 15 14:23:15 2014 -0400
Committer: Daniel Kulp <dk...@apache.org>
Committed: Fri Aug 15 14:23:15 2014 -0400
----------------------------------------------------------------------
.../src/main/java/org/apache/camel/util/ObjectHelper.java | 10 ++++++----
.../component/box/internal/LongPollingEventsManager.java | 1 -
.../main/java/org/apache/camel/maven/ApiMethodAlias.java | 1 -
.../src/main/java/org/apache/camel/maven/ApiProxy.java | 1 -
.../apache/camel/maven/FileApiMethodGeneratorMojo.java | 1 +
.../apache/camel/maven/JavadocApiMethodGeneratorMojo.java | 2 +-
.../src/main/resources/api-endpoint-config.vm | 1 -
.../src/main/resources/api-method-enum.vm | 1 -
8 files changed, 8 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/camel/blob/d292dbf2/camel-core/src/main/java/org/apache/camel/util/ObjectHelper.java
----------------------------------------------------------------------
diff --git a/camel-core/src/main/java/org/apache/camel/util/ObjectHelper.java b/camel-core/src/main/java/org/apache/camel/util/ObjectHelper.java
index e16e377..e769abb 100644
--- a/camel-core/src/main/java/org/apache/camel/util/ObjectHelper.java
+++ b/camel-core/src/main/java/org/apache/camel/util/ObjectHelper.java
@@ -43,6 +43,8 @@ import java.util.Map;
import java.util.NoSuchElementException;
import java.util.Properties;
import java.util.Scanner;
+import java.util.Set;
+import java.util.TreeSet;
import org.w3c.dom.Node;
import org.w3c.dom.NodeList;
@@ -67,10 +69,10 @@ import org.slf4j.LoggerFactory;
public final class ObjectHelper {
private static final Logger LOG = LoggerFactory.getLogger(ObjectHelper.class);
private static final String DEFAULT_DELIMITER = ",";
- @SuppressWarnings("unchecked")
- private static final List<?> PRIMITIVE_ARRAY_TYPES = Arrays.asList(byte[].class, short[].class, int[].class, long[].class,
- float[].class, double[].class, char[].class, boolean[].class);
-
+ private static final Set<Class<?>> PRIMITIVE_ARRAY_TYPES
+ = new TreeSet<Class<?>>(Arrays.asList(byte[].class, short[].class, int[].class, long[].class,
+ float[].class, double[].class, char[].class, boolean[].class));
+
/**
* Utility classes should not have a public constructor.
*/
http://git-wip-us.apache.org/repos/asf/camel/blob/d292dbf2/components/camel-box/src/main/java/org/apache/camel/component/box/internal/LongPollingEventsManager.java
----------------------------------------------------------------------
diff --git a/components/camel-box/src/main/java/org/apache/camel/component/box/internal/LongPollingEventsManager.java b/components/camel-box/src/main/java/org/apache/camel/component/box/internal/LongPollingEventsManager.java
index 66bb2b7..37611b7 100644
--- a/components/camel-box/src/main/java/org/apache/camel/component/box/internal/LongPollingEventsManager.java
+++ b/components/camel-box/src/main/java/org/apache/camel/component/box/internal/LongPollingEventsManager.java
@@ -90,7 +90,6 @@ public class LongPollingEventsManager {
}
}
- @SuppressWarnings("unused")
public void poll(long streamPosition, final String streamType, final int limit, final EventCallback callback)
throws BoxServerException, AuthFatalFailureException, BoxRestException {
http://git-wip-us.apache.org/repos/asf/camel/blob/d292dbf2/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/ApiMethodAlias.java
----------------------------------------------------------------------
diff --git a/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/ApiMethodAlias.java b/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/ApiMethodAlias.java
index 8002fba..71bb89e 100644
--- a/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/ApiMethodAlias.java
+++ b/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/ApiMethodAlias.java
@@ -19,7 +19,6 @@ package org.apache.camel.maven;
/**
* Represents method alias
*/
-@SuppressWarnings("unused")
public class ApiMethodAlias {
private String methodPattern;
http://git-wip-us.apache.org/repos/asf/camel/blob/d292dbf2/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/ApiProxy.java
----------------------------------------------------------------------
diff --git a/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/ApiProxy.java b/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/ApiProxy.java
index 5df0a7b..881998d 100644
--- a/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/ApiProxy.java
+++ b/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/ApiProxy.java
@@ -25,7 +25,6 @@ import org.apache.maven.plugin.MojoExecutionException;
/**
* Represents an API to use for generating Camel Component.
*/
-@SuppressWarnings("unused")
public class ApiProxy {
private String apiName;
http://git-wip-us.apache.org/repos/asf/camel/blob/d292dbf2/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/FileApiMethodGeneratorMojo.java
----------------------------------------------------------------------
diff --git a/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/FileApiMethodGeneratorMojo.java b/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/FileApiMethodGeneratorMojo.java
index 566ef0a..e011544 100644
--- a/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/FileApiMethodGeneratorMojo.java
+++ b/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/FileApiMethodGeneratorMojo.java
@@ -51,6 +51,7 @@ public class FileApiMethodGeneratorMojo extends AbstractApiMethodGeneratorMojo {
result.add(line);
line = reader.readLine();
}
+ reader.close();
} catch (FileNotFoundException e) {
throw new MojoExecutionException(e.getMessage(), e);
} catch (IOException e) {
http://git-wip-us.apache.org/repos/asf/camel/blob/d292dbf2/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/JavadocApiMethodGeneratorMojo.java
----------------------------------------------------------------------
diff --git a/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/JavadocApiMethodGeneratorMojo.java b/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/JavadocApiMethodGeneratorMojo.java
index dd76a02..6484692 100644
--- a/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/JavadocApiMethodGeneratorMojo.java
+++ b/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/JavadocApiMethodGeneratorMojo.java
@@ -78,7 +78,7 @@ public class JavadocApiMethodGeneratorMojo extends AbstractApiMethodGeneratorMoj
final Pattern excludeMethodPatterns = (excludeMethods != null) ? Pattern.compile(excludeMethods) : null;
// for proxy class and super classes not matching excluded packages or classes
- for (Class aClass = getProxyType();
+ for (Class<?> aClass = getProxyType();
aClass != null && !packagePatterns.matcher(aClass.getPackage().getName()).matches()
&& (classPatterns == null || !classPatterns.matcher(aClass.getSimpleName()).matches());
aClass = aClass.getSuperclass()) {
http://git-wip-us.apache.org/repos/asf/camel/blob/d292dbf2/tooling/maven/camel-api-component-maven-plugin/src/main/resources/api-endpoint-config.vm
----------------------------------------------------------------------
diff --git a/tooling/maven/camel-api-component-maven-plugin/src/main/resources/api-endpoint-config.vm b/tooling/maven/camel-api-component-maven-plugin/src/main/resources/api-endpoint-config.vm
index 6bc875f..082665f 100644
--- a/tooling/maven/camel-api-component-maven-plugin/src/main/resources/api-endpoint-config.vm
+++ b/tooling/maven/camel-api-component-maven-plugin/src/main/resources/api-endpoint-config.vm
@@ -27,7 +27,6 @@ import org.apache.camel.spi.UriParams;
/**
* Camel EndpointConfiguration for $proxyType.Name
*/
-@SuppressWarnings("unused")
@UriParams
public final class $configName extends ${componentName}Configuration {
#foreach( $parameter in $parameters.entrySet() )
http://git-wip-us.apache.org/repos/asf/camel/blob/d292dbf2/tooling/maven/camel-api-component-maven-plugin/src/main/resources/api-method-enum.vm
----------------------------------------------------------------------
diff --git a/tooling/maven/camel-api-component-maven-plugin/src/main/resources/api-method-enum.vm b/tooling/maven/camel-api-component-maven-plugin/src/main/resources/api-method-enum.vm
index 0bc3056..9dab27c 100644
--- a/tooling/maven/camel-api-component-maven-plugin/src/main/resources/api-method-enum.vm
+++ b/tooling/maven/camel-api-component-maven-plugin/src/main/resources/api-method-enum.vm
@@ -32,7 +32,6 @@ import org.apache.camel.util.component.ApiMethodImpl;
/**
* Camel {@link ApiMethod} Enumeration for $proxyType.Name
*/
-@SuppressWarnings("unused")
public enum $enumName implements ApiMethod {
#foreach ( $model in $models )