You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2026/07/05 22:12:29 UTC

[PR] fix: fix compilation warnings across all Scala versions [pekko-persistence-cassandra]

He-Pin opened a new pull request, #446:
URL: https://github.com/apache/pekko-persistence-cassandra/pull/446

   ### Motivation
   Compilation produced 8 warnings in Scala 2.13 test sources:
   - "getClass not selected from this instance" in CassandraSpec constructor default params (x2)
   - "a type was inferred to be `Any`" in CassandraIntegrationSpec
   - "private class Next is never used" in ManyActorsLoadSpec
   - "private val newPersistenceIdScan is never used" in EventsByTagPersistenceIdCleanupSpec
   - "Name e is already introduced in an enclosing scope" (x2) in EventsByTagSpec
   - "match may not be exhaustive" in ClusterShardingQuickTerminationSpec
   
   ### Modification
   - Add `@nowarn` annotation on CassandraSpec for intentional `getClass` usage in constructor default parameters
   - Add explicit `[Any]` type parameter to `expectMsgAllOf` call in CassandraIntegrationSpec
   - Remove unused private case class `Next` from ManyActorsLoadSpec
   - Remove unused private val `newPersistenceIdScan` from EventsByTagPersistenceIdCleanupSpec
   - Rename shadowed pattern variable `e` to `env` in EventsByTagSpec (x2)
   - Add catch-all case to `extractShardId` partial function for exhaustiveness
   
   ### Result
   Clean compilation with zero warnings across all Scala versions (2.13 and 3).
   
   ### Tests
   - `sbt +test:compile` - all versions pass with no warnings
   
   ### References
   None - code quality improvement


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] fix: fix compilation warnings across all Scala versions [pekko-persistence-cassandra]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #446:
URL: https://github.com/apache/pekko-persistence-cassandra/pull/446


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org