You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/28 00:30:59 UTC

[GitHub] [spark] srowen commented on a change in pull request #24231: [minor] remove import scala.collection.Set in TaskSchedulerImpl

srowen commented on a change in pull request #24231: [minor] remove import scala.collection.Set in TaskSchedulerImpl
URL: https://github.com/apache/spark/pull/24231#discussion_r269821060
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
 ##########
 @@ -829,7 +828,7 @@ private[spark] class TaskSchedulerImpl(
    * Get a snapshot of the currently blacklisted nodes for the entire application.  This is
    * thread-safe -- it can be called without a lock on the TaskScheduler.
    */
-  def nodeBlacklist(): scala.collection.immutable.Set[String] = {
+  def nodeBlacklist(): Set[String] = {
     blacklistTrackerOpt.map(_.nodeBlacklist()).getOrElse(scala.collection.immutable.Set())
 
 Review comment:
   There's also a lot of import of `scala.collection.Map` in other classes, but that looks more legit: pattern matching, perhaps Java interop.
   
   Oh, I wonder if this will cause the signature of getExecutorsAliveOnHost to change... may need a MiMa exclusion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org