You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "kgyrtkirk (via GitHub)" <gi...@apache.org> on 2023/08/17 10:08:38 UTC
[PR] Imporve on incremental compilation (druid)
kgyrtkirk opened a new pull request, #14860:
URL: https://github.com/apache/druid/pull/14860
This patch fixes a few issues toward #14858
* some phony classes were added to enable maven to track the compilation of those classes
* cyclonedx [2.7.9](https://github.com/CycloneDX/cyclonedx-maven-plugin/releases/tag/cyclonedx-maven-plugin-2.7.9) seem to handle incremental compilation better; it had a PR relating to that
* needed to update root pom to `25`
* update antlr to 4.5.3
These changes enable incremental compilation up to the `sql` module; where `javacc` regenerater
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Imporve on incremental compilation (druid)
Posted by "kgyrtkirk (via GitHub)" <gi...@apache.org>.
kgyrtkirk commented on PR #14860:
URL: https://github.com/apache/druid/pull/14860#issuecomment-1683572005
cannot reproduce failure of `SinglePhaseParallelIndexingTest` from maven...merged master see if it passes now or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Imporve on incremental compilation (druid)
Posted by "github-code-scanning[bot] (via GitHub)" <gi...@apache.org>.
github-code-scanning[bot] commented on code in PR #14860:
URL: https://github.com/apache/druid/pull/14860#discussion_r1297058283
##########
processing/src/main/java/org/apache/druid/math/expr/BinaryLogicalOperatorExpr.java:
##########
@@ -29,6 +29,11 @@
import javax.annotation.Nullable;
import java.util.Objects;
+final class BinaryLogicalOperatorExpr
Review Comment:
## Unused classes and interfaces
Unused class: BinaryLogicalOperatorExpr is not referenced within this codebase. If not used as an external API it should be removed.
[Show more details](https://github.com/apache/druid/security/code-scanning/5698)
##########
processing/src/main/java/org/apache/druid/math/expr/BinaryMathOperatorExpr.java:
##########
@@ -31,6 +31,11 @@
// math operators live here
+final class BinaryMathOperatorExpr
Review Comment:
## Unused classes and interfaces
Unused class: BinaryMathOperatorExpr is not referenced within this codebase. If not used as an external API it should be removed.
[Show more details](https://github.com/apache/druid/security/code-scanning/5699)
##########
processing/src/main/java/org/apache/druid/math/expr/FunctionalExpr.java:
##########
@@ -30,6 +30,11 @@
import java.util.Set;
import java.util.stream.Collectors;
+final class FunctionalExpr
Review Comment:
## Unused classes and interfaces
Unused class: FunctionalExpr is not referenced within this codebase. If not used as an external API it should be removed.
[Show more details](https://github.com/apache/druid/security/code-scanning/5700)
##########
processing/src/main/java/org/apache/druid/math/expr/UnaryOperatorExpr.java:
##########
@@ -32,6 +32,12 @@
import java.math.BigInteger;
import java.util.Objects;
+
+final class UnaryOperatorExpr
Review Comment:
## Unused classes and interfaces
Unused class: UnaryOperatorExpr is not referenced within this codebase. If not used as an external API it should be removed.
[Show more details](https://github.com/apache/druid/security/code-scanning/5701)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Imporve on incremental compilation (druid)
Posted by "kgyrtkirk (via GitHub)" <gi...@apache.org>.
kgyrtkirk commented on PR #14860:
URL: https://github.com/apache/druid/pull/14860#issuecomment-1691541747
Thank you @cryptoe for reviewing/merging these changes! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Imporve on incremental compilation (druid)
Posted by "kgyrtkirk (via GitHub)" <gi...@apache.org>.
kgyrtkirk commented on PR #14860:
URL: https://github.com/apache/druid/pull/14860#issuecomment-1689818348
I've envountered #14861 again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Imporve on incremental compilation (druid)
Posted by "cryptoe (via GitHub)" <gi...@apache.org>.
cryptoe merged PR #14860:
URL: https://github.com/apache/druid/pull/14860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org