You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/05 15:59:53 UTC
[GitHub] [airflow] kimvanwyk opened a new pull request, #28747: dash in docker-compose
kimvanwyk opened a new pull request, #28747:
URL: https://github.com/apache/airflow/pull/28747
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
"docker compose" is used in the airflow-init instructions, while "docker-compose" is used elsewhere. This tiny change adds the dash.
I also added a dash to "docker-compose" in the instructions for enabling flower, although the dash is there in the published webpage.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kimvanwyk commented on pull request #28747: dash in docker-compose
Posted by GitBox <gi...@apache.org>.
kimvanwyk commented on PR #28747:
URL: https://github.com/apache/airflow/pull/28747#issuecomment-1372452780
Fair enough - I had assumed "docker-compose" was the intended command despite being outdated as it is used in several other places on the page. If "docker compose" is the intended command (which is indeed the modern command to use) then several updates are needed on the page to replace references to "docker-compose".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28747: dash in docker-compose
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28747:
URL: https://github.com/apache/airflow/pull/28747#issuecomment-1372837886
Yepw @kimvanwyk - @kaxil is very right - searching for all places where `docker-compose` is used and should be replaced with `docker compose` and also applying a human knowledge to make sure it is done properly (you seem to know very well about the problem) - is absolutely great way to become a contributor and give back for the free software you use.
I am also happy to review such PR - are you up to this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed pull request #28747: dash in docker-compose
Posted by GitBox <gi...@apache.org>.
kaxil closed pull request #28747: dash in docker-compose
URL: https://github.com/apache/airflow/pull/28747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #28747: dash in docker-compose
Posted by GitBox <gi...@apache.org>.
kaxil commented on PR #28747:
URL: https://github.com/apache/airflow/pull/28747#issuecomment-1372447406
`docker-compose` is not needed and is obsolete, check https://docs.docker.com/compose/reference/ or https://stackoverflow.com/a/66526176/5691525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28747: dash in docker-compose
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #28747:
URL: https://github.com/apache/airflow/pull/28747#issuecomment-1372405287
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #28747: dash in docker-compose
Posted by GitBox <gi...@apache.org>.
kaxil commented on PR #28747:
URL: https://github.com/apache/airflow/pull/28747#issuecomment-1372455467
> Fair enough - I had assumed "docker-compose" was the intended command despite being outdated as it is used in several other places on the page. If "docker compose" is the intended command (which is indeed the modern command to use) then several updates are needed on the page to replace references to "docker-compose".
agreed, happy to merge - if you can create a new PR with that change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org