[jira] [Resolved] (AIRFLOW-2106) Cannot pass sandbox argument to sales_force hook preventing sandbox connection

["Fokko Driesprong (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AIRFLOW-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fokko Driesprong resolved AIRFLOW-2106.
---------------------------------------
       Resolution: Fixed
    Fix Version/s: 2.0.0

Issue resolved by pull request #3111
[https://github.com/apache/incubator-airflow/pull/3111]

> Cannot pass sandbox argument to sales_force hook preventing sandbox connection
> ------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-2106
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2106
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: contrib, hooks
>    Affects Versions: 1.8.0, 1.9.0
>         Environment: any
>            Reporter: Rob Liddle
>            Assignee: Tao Feng
>            Priority: Trivial
>              Labels: easyfix, newbie
>             Fix For: 2.0.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> In the salesforce_hook we pass a number of variables on to the simple-salesforce library.
> We do not pass or allow passing of the sandbox value - which means it defaults to false inside the simple-salesforce library.
> This value is required in order to connect to a salesforce sandbox testing environment. Without it the connection fails saying invalid credentials (even if they are correct).
> Link to hook section:
> [https://github.com/apache/incubator-airflow/blob/a592e732356427b4fd1ed27c890cf82e9cf495f0/airflow/contrib/hooks/salesforce_hook.py#L78]
> Link to simple-salesforce args:
> [https://github.com/simple-salesforce/simple-salesforce/blob/364c889abe9e22b7145524f2dc422e41c5f0639b/simple_salesforce/login.py#L24] 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)